From: Jaehoon Chung <jh80.chung@samsung.com>
To: Chris Ball <chris@printf.net>, linux-mmc@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists
Date: Thu, 05 Jun 2014 07:56:15 +0900 [thread overview]
Message-ID: <538FA40F.5040509@samsung.com> (raw)
In-Reply-To: <86mwdspk58.fsf@void.printf.net>
Hi, Chris.
Didn't you want to merge the below patch?
https://patchwork.kernel.org/patch/4239541/
I have tested with exynos series, and working fine.
Best Regards,
Jaehoon Chung
On 06/05/2014 04:08 AM, Chris Ball wrote:
> "mmc: sdhci: push card_tasklet into threaded irq handler" removed
> the card_tasklet, but it is still in use by sdhci-s3c.c.
>
> Signed-off-by: Chris Ball <chris@printf.net>
> ---
> Hi,
>
> sdhci-s3c is currently failing to build due to the removal of
> card_tasklet. I think this trivial patch might do the right
> thing -- please could someone test that card detection still
> works and ACK if so? Thanks!
>
> drivers/mmc/host/sdhci-s3c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 781b8a9..53a32e2 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state)
> clk_disable_unprepare(sc->clk_io);
> #endif
> }
> - tasklet_schedule(&host->card_tasklet);
> spin_unlock_irqrestore(&host->lock, flags);
> }
> }
>
next prev parent reply other threads:[~2014-06-04 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 19:08 [PATCH] mmc: sdhci-s3c: Remove use of card_tasklet, which no longer exists Chris Ball
2014-06-04 22:56 ` Jaehoon Chung [this message]
2014-06-05 2:13 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538FA40F.5040509@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tomasz.figa@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox