From: Jaehoon Chung <jh80.chung@samsung.com>
To: Tushar Behera <trblinux@gmail.com>, linux-mmc@vger.kernel.org
Cc: chris@printf.net, ulf.hansson@linaro.org, tgih.jun@samsung.com,
devicetree@vger.kernel.org, heiko@sntech.de, dinguyen@altera.com,
mark.rutland@arm.com, tushar.behera@linaro.org
Subject: Re: [PATCHv4 2/2] ARM: dts: unuse the slot-node and deprecated support-highspeed for dw-mmc.
Date: Thu, 05 Jun 2014 13:34:02 +0900 [thread overview]
Message-ID: <538FF33A.3020104@samsung.com> (raw)
In-Reply-To: <538FDF5D.9060400@gmail.com>
On 06/05/2014 12:09 PM, Tushar Behera wrote:
> On 06/05/2014 07:52 AM, Jaehoon Chung wrote:
>> dw-mmc controller can support the multiple slot.
>
> 'the' can be omitted, /s/slot/slots/
>
>> But, there is not use-case anywhere. So we don't need to support the
>
> /s/is not use-case/are no use-cases/
Will fix.
>
>> slot-node for dw-mmc controller.
>> And "support-highspeed" property in dw-mmc is deprecated.
>> "support-highspeed" property can be replaced to "cap-sd/mmc-highspeed".
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> [ ... ]
>
>> diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
>> index 532b1d4..60d90c9 100644
>> --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
>> +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
>> @@ -46,13 +46,14 @@ Required Properties:
>> - if CIU clock divider value is 0 (that is divide by 1), both tx and rx
>> phase shift clocks should be 0.
>>
>> -Required properties for a slot:
>> +Required properties for a slot (Deprecated - Support the one slot per host):
>
> "Support only one slot per host" ?
Don't need to support the multiple slots at dw-mmc controller.
Recommend to use one slot per a host.
>
>>
>> * gpios: specifies a list of gpios used for command, clock and data bus. The
>> first gpio is the command line and the second gpio is the clock line. The
>> rest of the gpios (depending on the bus-width property) are the data lines in
>> no particular order. The format of the gpio specifier depends on the gpio
>> controller.
>> + (Deprecated - Refer to Documentaion/devicetree/binding/samsung-pinctrl.txt)
>
> Update reference:
> Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
Will Fix
Thanks for comments.
Best Regards,
Jaehoon Chung
>
prev parent reply other threads:[~2014-06-05 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 2:22 [PATCHv4 0/4] mmc: fixed the mmc_of_parse for dwmmc Jaehoon Chung
2014-06-05 2:22 ` [PATCHv4 1/2] mmc: dw_mmc: replace "disable-wp" from slot's quirk to host's quirk Jaehoon Chung
2014-06-05 2:22 ` [PATCHv4 2/2] ARM: dts: unuse the slot-node and deprecated support-highspeed for dw-mmc Jaehoon Chung
2014-06-05 3:09 ` Tushar Behera
2014-06-05 4:34 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538FF33A.3020104@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=heiko@sntech.de \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=tgih.jun@samsung.com \
--cc=trblinux@gmail.com \
--cc=tushar.behera@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox