From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] ARM: bcm_defconfig: re-enable BCM Kona SDHCI driver Date: Mon, 16 Jun 2014 16:16:39 -0600 Message-ID: <539F6CC7.4010002@wwwdotorg.org> References: <1402941376-29594-1-git-send-email-mporter@linaro.org> <20140616215512.GC23430@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:50753 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756141AbaFPWQm (ORCPT ); Mon, 16 Jun 2014 18:16:42 -0400 In-Reply-To: <20140616215512.GC23430@n2100.arm.linux.org.uk> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Arnd Bergmann Cc: Russell King - ARM Linux , Matt Porter , arm@kernel.org, Linux MMC List , Linux ARM Kernel List On 06/16/2014 03:55 PM, Russell King - ARM Linux wrote: > On Mon, Jun 16, 2014 at 01:56:16PM -0400, Matt Porter wrote: >> Since 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies", >> MMC_SDHCI_PLTFM is no longer selected by the BCM Kona SDHCI >> driver which is enabled in this defconfig. This results in the >> SDHCI driver not being built and a boot failure. Explictly >> enable MMC_SDHCI_PLTFM in bcm_defconfig so the BCM Kona SDHCI >> driver is built. > > I really don't understand why MMC_SDHCI_PLTFM isn't selected by the > sub-drivers. sdhci-pltfm.c is a library module, which is only > useful with one of the sub-drivers enabled. > > So, rather than providing a multitude of dependent options, why not > present people with: > > + sdhci drivers > + sdhci pci > + sdhci acpi > + Arasan > + Freescale eSDHC > + Nintendo Wii > + Dove > > and leave MMC_SDHCI_PLTFM as a hidden option whose purpose is to > enable building of sdhci-pltfm.c. CC'ing Arnd, as author of 5d01b7684b7e "mmc: simplify SDHCI Kconfig dependencies". I also forgot to do that on the patch that fixed multi_v7_defconfig for this:-(