linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Seeking correct git repo
@ 2014-06-25 19:28 Derek Simkowiak
  2014-06-26  1:08 ` Hsin-Hsiang Tseng
  2014-06-26  9:35 ` Ulf Hansson
  0 siblings, 2 replies; 6+ messages in thread
From: Derek Simkowiak @ 2014-06-25 19:28 UTC (permalink / raw)
  To: linux-mmc

      Hello,
A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:

http://comments.gmane.org/gmane.linux.kernel.mmc/23795

I need this patch for my hardware.  But I don't see this patch in Linux 
stable (even though there are more recent patches from Seungwon Jeon in 
there), and I don't see it at the MMC repo either:

$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git

# Where's the patch? I checked all branches...

$ git branch -a
* master
   remotes/origin/HEAD -> origin/master
   remotes/origin/master
   remotes/origin/mmc-next
   remotes/origin/mmc-updates-for-3.16-rc1-merged


Can you please tell me, what is the repo and branch where this patch was 
submitted?  The only reference I have to this patch is the email archive 
at the URL above.


Thank You,
Derek


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Seeking correct git repo
  2014-06-25 19:28 Seeking correct git repo Derek Simkowiak
@ 2014-06-26  1:08 ` Hsin-Hsiang Tseng
  2014-06-26  9:35 ` Ulf Hansson
  1 sibling, 0 replies; 6+ messages in thread
From: Hsin-Hsiang Tseng @ 2014-06-26  1:08 UTC (permalink / raw)
  To: Derek Simkowiak; +Cc: linux-mmc@vger.kernel.org

I have the same question too.

I think we can't get a patch from Linux stable, which isn't accepted
by community.

I used a hard way to get a relative patch which i want by copy source
code from URL and recompile...

Best Regards,
Hsinhsiang

2014-06-26 3:28 GMT+08:00 Derek Simkowiak <derek@webtuner.tv>:
>      Hello,
> A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:
>
> http://comments.gmane.org/gmane.linux.kernel.mmc/23795
>
> I need this patch for my hardware.  But I don't see this patch in Linux
> stable (even though there are more recent patches from Seungwon Jeon in
> there), and I don't see it at the MMC repo either:
>
> $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
>
> # Where's the patch? I checked all branches...
>
> $ git branch -a
> * master
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/master
>   remotes/origin/mmc-next
>   remotes/origin/mmc-updates-for-3.16-rc1-merged
>
>
> Can you please tell me, what is the repo and branch where this patch was
> submitted?  The only reference I have to this patch is the email archive at
> the URL above.
>
>
> Thank You,
> Derek
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Seeking correct git repo
  2014-06-25 19:28 Seeking correct git repo Derek Simkowiak
  2014-06-26  1:08 ` Hsin-Hsiang Tseng
@ 2014-06-26  9:35 ` Ulf Hansson
  2014-06-26 18:27   ` Derek Simkowiak
  1 sibling, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2014-06-26  9:35 UTC (permalink / raw)
  To: Derek Simkowiak, linux-mmc



On 25 juni 2014 21:28:57 CEST, Derek Simkowiak <derek@webtuner.tv> wrote:
>      Hello,
>A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:
>
>http://comments.gmane.org/gmane.linux.kernel.mmc/23795
>
>I need this patch for my hardware.  But I don't see this patch in Linux
>
>stable (even though there are more recent patches from Seungwon Jeon in
>
>there), and I don't see it at the MMC repo either:
>
>$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
>
># Where's the patch? I checked all branches...
>
>$ git branch -a
>* master
>   remotes/origin/HEAD -> origin/master
>   remotes/origin/master
>   remotes/origin/mmc-next
>   remotes/origin/mmc-updates-for-3.16-rc1-merged
>
>
>Can you please tell me, what is the repo and branch where this patch
>was 
>submitted?  The only reference I have to this patch is the email
>archive 
>at the URL above.

Seems like it was missed. That could happen, then you should either send a ping or resend the patch.

Kind regards
Uffe
>
>
>Thank You,
>Derek
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: Seeking correct git repo
  2014-06-26  9:35 ` Ulf Hansson
@ 2014-06-26 18:27   ` Derek Simkowiak
  2014-06-27  8:51     ` [PATCH v2] mmc: Allow forward compatibility for e⋅MMC Romain Izard
  0 siblings, 1 reply; 6+ messages in thread
From: Derek Simkowiak @ 2014-06-26 18:27 UTC (permalink / raw)
  To: Ulf Hansson; +Cc: linux-mmc, romain.izard.pro

   Uffe,
Thank you for your prompt response.

 >///you should either send a ping or resend the patch./

I am happy to copy'n'paste the patch from the URL (below) and resend it 
to this list.

However, my understanding is that the email header "from " or "From:" 
lines are used to track authorship in the CONTRIBUTORS file.  I don't 
want to receive credit for Romain's work by re-sending his patch.  Is 
there a way for me to re-submit the patch on Romain's behalf?  (I have 
also CC:'d Romain, so he can resubmit it directly.)

I can verify that this patch is necessary to make Jedec 5.0 hardware 
work.  It should get into linux-stable as soon as possible, so that 
Linux can support newer eMMC hardware.


Thank You,
Derek

On 06/26/2014 02:35 AM, Ulf Hansson wrote:
> On 25 juni 2014 21:28:57 CEST, Derek Simkowiak<derek@webtuner.tv>  wrote:
>>       Hello,
>> A while ago, Romain wrote a small eMMC 5.0 patch that Ulf ack'd:
>>
>> http://comments.gmane.org/gmane.linux.kernel.mmc/23795
>>
>> I need this patch for my hardware.  But I don't see this patch in Linux
>>
>> stable (even though there are more recent patches from Seungwon Jeon in
>>
>> there), and I don't see it at the MMC repo either:
>>
>> $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
>>
>> # Where's the patch? I checked all branches...
>>
>> $ git branch -a
>> * master
>>    remotes/origin/HEAD -> origin/master
>>    remotes/origin/master
>>    remotes/origin/mmc-next
>>    remotes/origin/mmc-updates-for-3.16-rc1-merged
>>
>>
>> Can you please tell me, what is the repo and branch where this patch
>> was
>> submitted?  The only reference I have to this patch is the email
>> archive
>> at the URL above.
> Seems like it was missed. That could happen, then you should either send a ping or resend the patch.
>
> Kind regards
> Uffe
>> Thank You,
>> Derek
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message tomajordomo@vger.kernel.org
>> More majordomo info athttp://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] mmc: Allow forward compatibility for e⋅MMC
  2014-06-26 18:27   ` Derek Simkowiak
@ 2014-06-27  8:51     ` Romain Izard
  2014-07-08 12:26       ` Ulf Hansson
  0 siblings, 1 reply; 6+ messages in thread
From: Romain Izard @ 2014-06-27  8:51 UTC (permalink / raw)
  To: Chris Ball, Ulf Hansson, linux-mmc, Derek Simkowiak; +Cc: Romain Izard

As stated by the e⋅MMC 5.0 specification, a chip should not be rejected
only because of the revision stated in the EXT_CSD_REV field of the
EXT_CSD register.

Remove the control on this value, the control of the CSD_STRUCTURE field
should be sufficient to reject future incompatible changes.

Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/mmc/core/mmc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 1ab5f3a0af5b..ac9b8232133c 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -293,13 +293,12 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
 		}
 	}
 
+	/*
+	 * The EXT_CSD format is meant to be forward compatible. As long
+	 * as CSD_STRUCTURE does not change, all values for EXT_CSD_REV
+	 * are authorized, see JEDEC JESD84-B50 section B.8.
+	 */
 	card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-	if (card->ext_csd.rev > 7) {
-		pr_err("%s: unrecognised EXT_CSD revision %d\n",
-			mmc_hostname(card->host), card->ext_csd.rev);
-		err = -EINVAL;
-		goto out;
-	}
 
 	card->ext_csd.raw_sectors[0] = ext_csd[EXT_CSD_SEC_CNT + 0];
 	card->ext_csd.raw_sectors[1] = ext_csd[EXT_CSD_SEC_CNT + 1];
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v2] mmc: Allow forward compatibility for e⋅MMC
  2014-06-27  8:51     ` [PATCH v2] mmc: Allow forward compatibility for e⋅MMC Romain Izard
@ 2014-07-08 12:26       ` Ulf Hansson
  0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2014-07-08 12:26 UTC (permalink / raw)
  To: Romain Izard; +Cc: Chris Ball, linux-mmc, Derek Simkowiak

On 27 June 2014 10:51, Romain Izard <romain.izard.pro@gmail.com> wrote:
> As stated by the e⋅MMC 5.0 specification, a chip should not be rejected
> only because of the revision stated in the EXT_CSD_REV field of the
> EXT_CSD register.
>
> Remove the control on this value, the control of the CSD_STRUCTURE field
> should be sufficient to reject future incompatible changes.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Thanks! Applied for next.

Kind regards
Uffe


> ---
>  drivers/mmc/core/mmc.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 1ab5f3a0af5b..ac9b8232133c 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -293,13 +293,12 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
>                 }
>         }
>
> +       /*
> +        * The EXT_CSD format is meant to be forward compatible. As long
> +        * as CSD_STRUCTURE does not change, all values for EXT_CSD_REV
> +        * are authorized, see JEDEC JESD84-B50 section B.8.
> +        */
>         card->ext_csd.rev = ext_csd[EXT_CSD_REV];
> -       if (card->ext_csd.rev > 7) {
> -               pr_err("%s: unrecognised EXT_CSD revision %d\n",
> -                       mmc_hostname(card->host), card->ext_csd.rev);
> -               err = -EINVAL;
> -               goto out;
> -       }
>
>         card->ext_csd.raw_sectors[0] = ext_csd[EXT_CSD_SEC_CNT + 0];
>         card->ext_csd.raw_sectors[1] = ext_csd[EXT_CSD_SEC_CNT + 1];
> --
> 1.9.1
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-07-08 12:26 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 19:28 Seeking correct git repo Derek Simkowiak
2014-06-26  1:08 ` Hsin-Hsiang Tseng
2014-06-26  9:35 ` Ulf Hansson
2014-06-26 18:27   ` Derek Simkowiak
2014-06-27  8:51     ` [PATCH v2] mmc: Allow forward compatibility for e⋅MMC Romain Izard
2014-07-08 12:26       ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).