Re: [PATCH] mmc: add new au6601 driver

Oleksij Rempel
2014-09-30T10:12:11Z

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Am 09.07.2014 um 14:52 schrieb Ulf Hansson:
> [snip]
>
>>>
>>> I am just a bit curious, does this controller support hardware busy
>>> detection on DAT1 line while waiting for command completion?
>>
>> Do you mean AU6601_REG_BUS_STATUS?
>> See at the beginning of patch.
>
> While reviewing the code, it seems like the controller are handling
> hardware busy detection on DAT1. On the other hand you don't enable
> MMC_CAP_WAIT_WHILE_BUSY, shouldn't you be doing that?

Hi Ulf,

what is better way to use sg with dma? This controller support only
0x4000 alight addresses. It is possible to solve it per driver basis,
but i have seen already more then one driver which need it. Should it be
done in mmc block code? Any other suggestions?

Thank you,
--
Regards,
Oleksij

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]