From: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
chris@printf.net, ulf.hansson@linaro.org, tgih.jun@samsung.com,
aaron.lu@intel.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, jackey.shen@amd.com,
gregkh@linuxfoundation.org
Subject: Re: One bug of SDHCI driver
Date: Wed, 09 Jul 2014 00:03:26 +0800 [thread overview]
Message-ID: <53BC164E.4040900@linux.intel.com> (raw)
In-Reply-To: <53B968EB.60401@linux.intel.com>
Hi,
Why add "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" ? How to fix this bug?
Could you please give out some idea about this bug?
Thanks,
Zhonghui
On 2014/7/6 23:19, Fu, Zhonghui wrote:
> Yes, "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" of "sdhci_add_host" function in host/sdhci.c file make oops.
>
> "sdio_card_irq_get" function in core/sdio_irq.c file:
> if (!(host->caps2 & MMC_CAP2_SDIO_IRQ_NOTHREAD)) { /* the condition is false */
> atomic_set(&host->sdio_irq_thread_abort, 0);
> host->sdio_irq_thread =
> kthread_run(sdio_irq_thread, host,
> "ksdioirqd/%s", mmc_hostname(host));
>
>
> This will make "host->sdio_irq_thread" a NULL pointer in "mmc_sdio_resume" functon of core/sdio.c file.
>
>
>
> Thanks,
> Zhonghui
>
>
>
> On 2014/7/4 10:40, Jaehoon Chung wrote:
>> Hi,
>>
>> just use the MMC_CAP2_SDIO_IRQ_NOTHREAD?
>>
>> if (!err && host->sdio_irq && !(host->quirks & MMC_CAP2_SDIO_IRQ_NOTHREAD))
>> wake_up_process(host->sdio_irq_thread);
>>
>> I didn't test this..but i believe that it will be fixed.
>>
>> Best Regards,
>> Jaehoon Chung
>>
>> On 07/04/2014 12:47 AM, Fu, Zhonghui wrote:
>>> Hi, all
>>>
>>> The statement "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" is added in "sdhci_add_host" function in host/sdhci.c file. In some cases, this will make "host->sdio_irq_thread" a NULL pointer in "mmc_sdio_resume" functon of core/sdio.c file and lead to resume failure. Could you please give me some advice how to fix this bug?
>>>
>>>
>>>
>>> Thanks,
>>> Zhonghui
>>>
>>>
>>>
>>>
>>>
>>>
next prev parent reply other threads:[~2014-07-08 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 5:39 one doubt about mmc_sdio_init_card function Fu, Zhonghui
2014-07-02 2:52 ` Aaron Lu
2014-07-03 15:47 ` One bug of SDHCI driver Fu, Zhonghui
2014-07-04 2:40 ` Jaehoon Chung
2014-07-06 15:19 ` Fu, Zhonghui
2014-07-08 16:03 ` Fu, Zhonghui [this message]
2014-07-14 13:26 ` Chris Ball
2014-07-15 2:54 ` Fu, Zhonghui
2014-07-15 4:14 ` Jaehoon Chung
2014-07-15 4:40 ` Jaehoon Chung
2014-07-20 14:51 ` Fu, Zhonghui
2014-07-24 15:27 ` Fu, Zhonghui
[not found] ` <53D85CBF.3070409@linux.intel.com>
2014-07-30 3:40 ` Jaehoon Chung
2014-08-05 4:56 ` Fu, Zhonghui
2014-08-07 6:58 ` Fu, Zhonghui
2014-08-11 5:53 ` Fu, Zhonghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC164E.4040900@linux.intel.com \
--to=zhonghui.fu@linux.intel.com \
--cc=aaron.lu@intel.com \
--cc=chris@printf.net \
--cc=gregkh@linuxfoundation.org \
--cc=jackey.shen@amd.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).