* [PATCH] mmc: core: export more sysfs for debugging purpose @ 2014-08-12 7:28 Yunpeng Gao 2014-08-12 8:49 ` Jaehoon Chung 0 siblings, 1 reply; 3+ messages in thread From: Yunpeng Gao @ 2014-08-12 7:28 UTC (permalink / raw) To: linux-mmc; +Cc: Yunpeng Gao, Chuanxiao Xiao Add some more sysfs export related to eMMC BK Ops, HPI and Hardware Reset features. It'll be helpful for debugging. Signed-off-by: Yunpeng Gao <yunpeng.gao@intel.com> Signed-off-by: Chuanxiao Xiao <chuanxiao.dong@intel.com> --- drivers/mmc/core/mmc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 793c6f7..15b7ab0 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -710,6 +710,12 @@ MMC_DEV_ATTR(enhanced_area_offset, "%llu\n", MMC_DEV_ATTR(enhanced_area_size, "%u\n", card->ext_csd.enhanced_area_size); MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", card->ext_csd.raw_rpmb_size_mult); MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors); +MMC_DEV_ATTR(hpi_support, "%d\n", card->ext_csd.hpi); +MMC_DEV_ATTR(hpi_enable, "%d\n", card->ext_csd.hpi_en); +MMC_DEV_ATTR(hpi_command, "%d\n", card->ext_csd.hpi_cmd); +MMC_DEV_ATTR(hw_reset_support, "%d\n", card->ext_csd.rst_n_function); +MMC_DEV_ATTR(bkops_support, "%d\n", card->ext_csd.bkops); +MMC_DEV_ATTR(bkops_enable, "%d\n", card->ext_csd.bkops_en); static struct attribute *mmc_std_attrs[] = { &dev_attr_cid.attr, @@ -728,6 +734,12 @@ static struct attribute *mmc_std_attrs[] = { &dev_attr_enhanced_area_size.attr, &dev_attr_raw_rpmb_size_mult.attr, &dev_attr_rel_sectors.attr, + &dev_attr_hpi_support.attr, + &dev_attr_hpi_enable.attr, + &dev_attr_hpi_command.attr, + &dev_attr_hw_reset_support.attr, + &dev_attr_bkops_support.attr, + &dev_attr_bkops_enable.attr, NULL, }; ATTRIBUTE_GROUPS(mmc_std); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: core: export more sysfs for debugging purpose 2014-08-12 7:28 [PATCH] mmc: core: export more sysfs for debugging purpose Yunpeng Gao @ 2014-08-12 8:49 ` Jaehoon Chung 2014-08-13 6:18 ` Gao, Yunpeng 0 siblings, 1 reply; 3+ messages in thread From: Jaehoon Chung @ 2014-08-12 8:49 UTC (permalink / raw) To: Yunpeng Gao, linux-mmc; +Cc: Chuanxiao Xiao Hi, On 08/12/2014 04:28 PM, Yunpeng Gao wrote: > Add some more sysfs export related to eMMC BK Ops, > HPI and Hardware Reset features. It'll be helpful > for debugging. Did you use "mmc-utils"? Best Regards, Jaehoon Chung > > Signed-off-by: Yunpeng Gao <yunpeng.gao@intel.com> > Signed-off-by: Chuanxiao Xiao <chuanxiao.dong@intel.com> > --- > drivers/mmc/core/mmc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 793c6f7..15b7ab0 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -710,6 +710,12 @@ MMC_DEV_ATTR(enhanced_area_offset, "%llu\n", > MMC_DEV_ATTR(enhanced_area_size, "%u\n", card->ext_csd.enhanced_area_size); > MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", card->ext_csd.raw_rpmb_size_mult); > MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors); > +MMC_DEV_ATTR(hpi_support, "%d\n", card->ext_csd.hpi); > +MMC_DEV_ATTR(hpi_enable, "%d\n", card->ext_csd.hpi_en); > +MMC_DEV_ATTR(hpi_command, "%d\n", card->ext_csd.hpi_cmd); > +MMC_DEV_ATTR(hw_reset_support, "%d\n", card->ext_csd.rst_n_function); > +MMC_DEV_ATTR(bkops_support, "%d\n", card->ext_csd.bkops); > +MMC_DEV_ATTR(bkops_enable, "%d\n", card->ext_csd.bkops_en); > > static struct attribute *mmc_std_attrs[] = { > &dev_attr_cid.attr, > @@ -728,6 +734,12 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_enhanced_area_size.attr, > &dev_attr_raw_rpmb_size_mult.attr, > &dev_attr_rel_sectors.attr, > + &dev_attr_hpi_support.attr, > + &dev_attr_hpi_enable.attr, > + &dev_attr_hpi_command.attr, > + &dev_attr_hw_reset_support.attr, > + &dev_attr_bkops_support.attr, > + &dev_attr_bkops_enable.attr, > NULL, > }; > ATTRIBUTE_GROUPS(mmc_std); > ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] mmc: core: export more sysfs for debugging purpose 2014-08-12 8:49 ` Jaehoon Chung @ 2014-08-13 6:18 ` Gao, Yunpeng 0 siblings, 0 replies; 3+ messages in thread From: Gao, Yunpeng @ 2014-08-13 6:18 UTC (permalink / raw) To: Jaehoon Chung, linux-mmc@vger.kernel.org; +Cc: Dong, Chuanxiao HI Jaehoon, I have not tried mmc-utils yet. Actually, our validation team developed their own test cases of eMMC features and requested us to export these sysfs interfaces. Thanks. Regards, Yunpeng -----Original Message----- From: Jaehoon Chung [mailto:jh80.chung@samsung.com] Sent: Tuesday, August 12, 2014 4:50 PM To: Gao, Yunpeng; linux-mmc@vger.kernel.org Cc: Dong, Chuanxiao Subject: Re: [PATCH] mmc: core: export more sysfs for debugging purpose Hi, On 08/12/2014 04:28 PM, Yunpeng Gao wrote: > Add some more sysfs export related to eMMC BK Ops, HPI and Hardware > Reset features. It'll be helpful for debugging. Did you use "mmc-utils"? Best Regards, Jaehoon Chung > > Signed-off-by: Yunpeng Gao <yunpeng.gao@intel.com> > Signed-off-by: Chuanxiao Xiao <chuanxiao.dong@intel.com> > --- > drivers/mmc/core/mmc.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index > 793c6f7..15b7ab0 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -710,6 +710,12 @@ MMC_DEV_ATTR(enhanced_area_offset, "%llu\n", > MMC_DEV_ATTR(enhanced_area_size, "%u\n", > card->ext_csd.enhanced_area_size); > MMC_DEV_ATTR(raw_rpmb_size_mult, "%#x\n", > card->ext_csd.raw_rpmb_size_mult); > MMC_DEV_ATTR(rel_sectors, "%#x\n", card->ext_csd.rel_sectors); > +MMC_DEV_ATTR(hpi_support, "%d\n", card->ext_csd.hpi); > +MMC_DEV_ATTR(hpi_enable, "%d\n", card->ext_csd.hpi_en); > +MMC_DEV_ATTR(hpi_command, "%d\n", card->ext_csd.hpi_cmd); > +MMC_DEV_ATTR(hw_reset_support, "%d\n", card->ext_csd.rst_n_function); > +MMC_DEV_ATTR(bkops_support, "%d\n", card->ext_csd.bkops); > +MMC_DEV_ATTR(bkops_enable, "%d\n", card->ext_csd.bkops_en); > > static struct attribute *mmc_std_attrs[] = { > &dev_attr_cid.attr, > @@ -728,6 +734,12 @@ static struct attribute *mmc_std_attrs[] = { > &dev_attr_enhanced_area_size.attr, > &dev_attr_raw_rpmb_size_mult.attr, > &dev_attr_rel_sectors.attr, > + &dev_attr_hpi_support.attr, > + &dev_attr_hpi_enable.attr, > + &dev_attr_hpi_command.attr, > + &dev_attr_hw_reset_support.attr, > + &dev_attr_bkops_support.attr, > + &dev_attr_bkops_enable.attr, > NULL, > }; > ATTRIBUTE_GROUPS(mmc_std); > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-13 6:18 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-12 7:28 [PATCH] mmc: core: export more sysfs for debugging purpose Yunpeng Gao 2014-08-12 8:49 ` Jaehoon Chung 2014-08-13 6:18 ` Gao, Yunpeng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox