* re: mmc: mmci: Add qcom dml support to the driver.
@ 2014-08-28 13:21 Dan Carpenter
2014-09-01 9:02 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-08-28 13:21 UTC (permalink / raw)
To: srinivas.kandagatla; +Cc: linux-mmc
Hello Srinivas Kandagatla,
The patch 4dd5a1e6dd12: "mmc: mmci: Add qcom dml support to the
driver." from Jul 29, 2014, leads to the following static checker
warning:
drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init()
warn: unsigned 'producer_id' is never less than zero.
drivers/mmc/host/mmci_qcom_dml.c
121 /* Initialize the dml hardware connected to SD Card controller */
122 int dml_hw_init(struct mmci_host *host, struct device_node *np)
123 {
124 u32 config;
125 void __iomem *base;
126 u32 consumer_id, producer_id;
127
128 consumer_id = of_get_dml_pipe_index(np, "tx");
129 producer_id = of_get_dml_pipe_index(np, "rx");
130
131 if (producer_id < 0 || consumer_id < 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
132 return -ENODEV;
133
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: mmc: mmci: Add qcom dml support to the driver.
2014-08-28 13:21 mmc: mmci: Add qcom dml support to the driver Dan Carpenter
@ 2014-09-01 9:02 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2014-09-01 9:02 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-mmc
Hi Dan,
Thankyou for reporting this warning.
Both consumer_id and producer_id are supposed to be int instead of u32.
I will fix this.
Thanks,
srini
On 28/08/14 14:21, Dan Carpenter wrote:
> Hello Srinivas Kandagatla,
>
> The patch 4dd5a1e6dd12: "mmc: mmci: Add qcom dml support to the
> driver." from Jul 29, 2014, leads to the following static checker
> warning:
>
> drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init()
> warn: unsigned 'producer_id' is never less than zero.
>
> drivers/mmc/host/mmci_qcom_dml.c
> 121 /* Initialize the dml hardware connected to SD Card controller */
> 122 int dml_hw_init(struct mmci_host *host, struct device_node *np)
> 123 {
> 124 u32 config;
> 125 void __iomem *base;
> 126 u32 consumer_id, producer_id;
> 127
> 128 consumer_id = of_get_dml_pipe_index(np, "tx");
> 129 producer_id = of_get_dml_pipe_index(np, "rx");
> 130
> 131 if (producer_id < 0 || consumer_id < 0)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 132 return -ENODEV;
> 133
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-01 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-28 13:21 mmc: mmci: Add qcom dml support to the driver Dan Carpenter
2014-09-01 9:02 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).