From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Date: Sun, 14 Sep 2014 23:39:25 +0400 Message-ID: <5415EEED.3020204@cogentembedded.com> References: <2535223.qa7H57Aml3@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f171.google.com ([74.125.82.171]:58136 "EHLO mail-we0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752859AbaINUiD (ORCPT ); Sun, 14 Sep 2014 16:38:03 -0400 Received: by mail-we0-f171.google.com with SMTP id p10so3030216wes.16 for ; Sun, 14 Sep 2014 13:38:01 -0700 (PDT) In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: linux-mmc , Ian Molton , Chris Ball , Linux-sh list Hello. Sorry for delay: I'm on vacations and WiFi didn't work well here... On 09/08/2014 03:17 PM, Ulf Hansson wrote: >> I spent a couple of days with the driver just hanging due to me forgetting to >> specify the external crystal frequency, so that clk_get_rate() returned 0 and >> thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an >> acceptable behavior, so I suggest that the minimum frequency is checked for 0 >> in tmio_mmc_host_probe(). >> Signed-off-by: Sergei Shtylyov >> --- >> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch. > Hi Sergei, > Could you please base it towards "next" instead, it doesn't apply. If > you think this is important to go stable, I suggest you to add a > stable tag for it. It's a bit of a corner case, of course, but the consequences are just too disastrous: AFAIR, an ARM kernel just silently hangs on boot, with no hints of where. So I'm going to CC: -stable. > Kind regards > Uffe WBR, Sergei