From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Ian Molton <ian.molton@codethink.co.uk>,
Chris Ball <chris@printf.net>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock()
Date: Thu, 18 Sep 2014 19:54:59 +0300 [thread overview]
Message-ID: <541B0E63.9080605@cogentembedded.com> (raw)
In-Reply-To: <CAPDyKFq2H0zQjJvHy+Ogz0MbVsY8HAHDvDvr3+CTPvf0bc7xog@mail.gmail.com>
Hello.
On 9/18/2014 1:03 AM, Ulf Hansson wrote:
>> I spent a couple of days with the driver just hanging due to me forgetting to
>> specify the external crystal frequency, so that clk_get_rate() returned 0 and
>> thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an
>> acceptable behavior, so I suggest that the minimum frequency is checked for 0
>> in tmio_mmc_host_probe().
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> Cc: stable@vger.kernel.org
>> ---
>> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch.
> Hi Sergei,
> Could you please rebase it towards next instead?
Ah, I've misinterpreted your mail, thought that I should either rebase to
next /or/ CC: stable. Will do.
> Kind regards
> Uffe
WBR, Sergei
prev parent reply other threads:[~2014-09-18 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 19:51 [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Sergei Shtylyov
2014-09-15 11:14 ` Ian Molton
2014-09-17 22:03 ` Ulf Hansson
2014-09-18 16:54 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B0E63.9080605@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chris@printf.net \
--cc=ian.molton@codethink.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox