From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v3] tmio_mmc_pio: prevent endless loop in tmio_mmc_set_clock() Date: Thu, 18 Sep 2014 19:54:59 +0300 Message-ID: <541B0E63.9080605@cogentembedded.com> References: <3179866.4yEKrAKQ30@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:46386 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932125AbaIRQyt (ORCPT ); Thu, 18 Sep 2014 12:54:49 -0400 Received: by mail-wi0-f174.google.com with SMTP id n3so3504205wiv.7 for ; Thu, 18 Sep 2014 09:54:48 -0700 (PDT) In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: linux-mmc , Ian Molton , Chris Ball , Linux-sh list Hello. On 9/18/2014 1:03 AM, Ulf Hansson wrote: >> I spent a couple of days with the driver just hanging due to me forgetting to >> specify the external crystal frequency, so that clk_get_rate() returned 0 and >> thus the loop in tmio_mmc_set_clock() never ended. I don't think that's an >> acceptable behavior, so I suggest that the minimum frequency is checked for 0 >> in tmio_mmc_host_probe(). >> Signed-off-by: Sergei Shtylyov >> Cc: stable@vger.kernel.org >> --- >> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' branch. > Hi Sergei, > Could you please rebase it towards next instead? Ah, I've misinterpreted your mail, thought that I should either rebase to next /or/ CC: stable. Will do. > Kind regards > Uffe WBR, Sergei