Re: [PATCH/RFC] mmc: sh_mmcif: Increase MMCIF clock rate to 97.5MHz

Simon Horman
2014-11-13T00:24:48Z

On Thu, Nov 13, 2014 at 12:15:58AM +0000, Kuninori Morimoto wrote:
>
> Hi Kaneko-san
>
> > From: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> >
> > Signed-off-by: Shinobu Uehara <shinobu.uehara.xc@renesas.com>
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> > ---
> (snip)
> > + if (np && !of_property_read_u32(np, "renesas,clk-rate", &clk_rate)) {
> > + if (clk_rate) {
> > + ret = clk_set_rate(host->hclk, clk_rate);
> > + if (ret < 0)
> > + dev_err(&pdev->dev,
> > + "cannot set clock rate: %d\n", ret);
> > + }
> > + }
>
> I guess this is came from BSP, and you have similar
> bindings on sh_mobile_sdhi.c too.
> But, we need to use "standard" method, not BSP original

Hi Morimoto-san,

you are correct in assuming that this patch came from the BSP.

Is your opinion that a) changing the clock rate is good but
b) it needs to be done using a standard method?

If so, is the main change required to use a standard binding string
rather than "renesas,clk-rate"? Is the driver change above needed at all?