From: Jaehoon Chung <jh80.chung@samsung.com>
To: Beomho Seo <beomho.seo@samsung.com>, linux-mmc@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>, 'Chris Ball' <chris@printf.net>
Subject: Re: [PATCH] mmc: dw_mmc: remove unnecessary debug message
Date: Tue, 23 Dec 2014 21:51:41 +0900 [thread overview]
Message-ID: <5499655D.1040809@samsung.com> (raw)
In-Reply-To: <1419336453-6411-1-git-send-email-beomho.seo@samsung.com>
Plz CC'd the mmc maintainers and dw-mmc maintainers.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
On 12/23/2014 09:07 PM, Beomho Seo wrote:
> This patch remove unnecessary 'out of memory' message on dw mmc driver.
>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 4 +---
> drivers/mmc/host/dw_mmc.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index f936704..74eb081 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -230,10 +230,8 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)
> int ret;
>
> priv = devm_kzalloc(host->dev, sizeof(*priv), GFP_KERNEL);
> - if (!priv) {
> - dev_err(host->dev, "mem alloc failed for private data\n");
> + if (!priv)
> return -ENOMEM;
> - }
>
> for (idx = 0; idx < ARRAY_SIZE(exynos_compat); idx++) {
> if (of_device_is_compatible(np, exynos_compat[idx].compatible))
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index a1b80e5..6e4d864 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2546,10 +2546,8 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
> u32 clock_frequency;
>
> pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> - if (!pdata) {
> - dev_err(dev, "could not allocate memory for pdata\n");
> + if (!pdata)
> return ERR_PTR(-ENOMEM);
> - }
>
> /* find out number of slots supported */
> if (of_property_read_u32(dev->of_node, "num-slots",
>
next prev parent reply other threads:[~2014-12-23 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 12:07 [PATCH] mmc: dw_mmc: remove unnecessary debug message Beomho Seo
2014-12-23 12:51 ` Jaehoon Chung [this message]
2014-12-23 15:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5499655D.1040809@samsung.com \
--to=jh80.chung@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox