From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Holler Subject: Re: [PATCH] mmc: print message if a card supports secure erase/trim Date: Tue, 27 Jan 2015 13:02:49 +0100 Message-ID: <54C77E69.7050600@ahsoftware.de> References: <1422359304-30321-1-git-send-email-holler@ahsoftware.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h1446028.stratoserver.net ([85.214.92.142]:53627 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755485AbbA0MC5 (ORCPT ); Tue, 27 Jan 2015 07:02:57 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Richard Weinberger Cc: linux-mmc@vger.kernel.org, LKML , Chris Ball , Ulf Hansson Am 27.01.2015 um 12:55 schrieb Richard Weinberger: > On Tue, Jan 27, 2015 at 12:48 PM, Alexander Holler wrote: >> It's an interesting detail, so inform the user about it. >> >> Signed-off-by: Alexander Holler >> --- >> drivers/mmc/core/bus.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c >> index 8a1f124..4a60028 100644 >> --- a/drivers/mmc/core/bus.c >> +++ b/drivers/mmc/core/bus.c >> @@ -347,6 +347,10 @@ int mmc_add_card(struct mmc_card *card) >> uhs_bus_speed_mode, type, card->rca); >> } >> >> + if (mmc_can_secure_erase_trim(card)) >> + pr_info("%s: card supports secure erase/trim\n", >> + mmc_hostname(card->host)); >> + > > Please make this a sysfs attribute. > Exposing such properties as log messages is horrible. Look at the source at the message which is printed just before and decide which one you find more informational / useful. Alexander Holler