Re: [PATCH] mmc: print message if a card supports secure erase/trim

Richard Weinberger
2015-01-27T12:31:32Z

Am 27.01.2015 um 13:15 schrieb Alexander Holler:
> Am 27.01.2015 um 13:08 schrieb Borislav Petkov:
>> On Tue, Jan 27, 2015 at 01:02:49PM +0100, Alexander Holler wrote:
>>> Look at the source at the message which is printed just before and decide
>>> which one you find more informational / useful.
>>
>> I find such a message absolutely useless. Also, if it flies off and
>> printk buffer gets overwritten, it serves you sh*t. IOW, listen to what
>> Richard tells you.
>
> Ok. I shut/give up.

There is no need to be sulky.

> Maybe you could be so nice to inform me where the similiar detail is exposed in sysfs for SSDs.

If it is not already exposed and you can come up with a sane use case send a patch.

> Also it's unlikely I will send any further patch. There are still 21 from me where I've exposed sysfs attributes for NAND devices which are still not applied and most NAND devices
> still don't have a sysfs entry.
>
> So why should I waste my time again?

If you give up after the first review round there is nothing I can do for you.
Postings like https://lkml.org/lkml/2014/5/30/162 are also not really beneficial
to get a patch merged.

Thanks,
//richard

P.s. If you see every not-merged patch as a waste of time, please stop developing software as
it is obviously not an enjoyment for you.