Re: [PATCH] mmc: print message if a card supports secure erase/trim

Borislav Petkov
2015-01-27T14:21:33Z

On Tue, Jan 27, 2015 at 01:44:15PM +0100, Alexander Holler wrote:
> Yes. Sorry, but I had so many bad experiences with maintainers.

Well, I can't comment on your experience for the simple reason that I
haven't followed those discussions. In their defence, though, you have
to know that those people get to review your code, apply it and then
deal with it long after you've gone on about doing other things.

So, even if you don't always agree with them, you need to realize that
those are the people responsible for that code and if they request a
reasonable change in your submission, you have to do it. It is that
simple.

[ Unless you have a good argument against it but that's a different
story and this is what is called the "review" process. ]

But this is how basically linux kernel development is done. It is not
about simply doing something but about doing it right. And as long as
you get *reasonable* change requests for your patch, you go and change
it.

And yes, not only *you* but *we* all have to redo our patches. And it
is not unheard of people working on a single feature for months if not
years, doing changes, doing changes again, testing variants and so on
and so on. Simply reading lkml would give you lots of examples.

And yet we still do it because it is simply great fun and one gets to
learn tons of new things when working with the community (don't listen
to all that bullshit about the kernel community being unfriendly - the
real problem there is most of the time somewhere else).

But instead of having fun, you're frustrated. And people should not be
frustrated because that is generally bad for their health. So maybe you
should sit down, take a quiet minute and think about what you actually
want to do. And if kernel development doesn't give you any fun, then
you're probably on the right track with not wanting to do it anymore.

If it were me, I'd stop doing it too if it is not fun anymore - life's
too short to be frustrated and not have fun. It is cheesy but it is
true.

I sincerely hope that helps in any way.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--