Re: [PATCH 5/7] mmc: sdhci-bcm-kona: kill the "external_clk" member in driver private struct

Kevin Hao
2015-02-06T06:40:10Z

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

On Thu, Feb 05, 2015 at 09:51:17PM -0800, Ray Jui wrote:
> > @@ -265,19 +264,19 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> > }
> >
> > /* Get and enable the external clock */
>
> Would you mind changing the above comment to "/* Get and enable the core
> clock */?

Sure.

>
> > - kona_dev->external_clk = devm_clk_get(dev, NULL);
> > - if (IS_ERR(kona_dev->external_clk)) {
> > + pltfm_priv->clk = devm_clk_get(dev, NULL);
> > + if (IS_ERR(pltfm_priv->clk)) {
> > dev_err(dev, "Failed to get external clock\n");
>
> Change to "Failed to get the core clock"

OK, I will change all the references of "external clock" to "core clock".

> Not sure if this is relevant and should be done in the same patch. But
> both callbacks get_max_clock and get_timeout_clock in this driver can be
> set to sdhci_pltfm_clk_get_max_clock. That will help to get rid of two
> redundant private functions in this driver.

Sounds good. I will add this in the v2.

Thanks,
Kevin

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]