From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH V2 15/15] mmc: core: Don't print reset warning if reset is not supported Date: Mon, 09 Feb 2015 11:47:00 +0200 Message-ID: <54D88214.5000204@intel.com> References: <1422522030-17793-1-git-send-email-adrian.hunter@intel.com> <1422522030-17793-16-git-send-email-adrian.hunter@intel.com> <54D87EFC.9060404@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:31481 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759979AbbBIJsx (ORCPT ); Mon, 9 Feb 2015 04:48:53 -0500 In-Reply-To: <54D87EFC.9060404@broadcom.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Arend van Spriel Cc: Ulf Hansson , Chris Ball , linux-mmc , Aaron Lu , Philip Rakity , Girish K S , Al Cooper On 09/02/15 11:33, Arend van Spriel wrote: > On 01/29/15 10:00, Adrian Hunter wrote: >> Check the error code for EOPNOTSUPP and do not print >> reset warning in that case. >> >> Signed-off-by: Adrian Hunter >> --- >> drivers/mmc/core/core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c >> index 392a150..d439bf0 100644 >> --- a/drivers/mmc/core/core.c >> +++ b/drivers/mmc/core/core.c >> @@ -2368,7 +2368,8 @@ int mmc_hw_reset(struct mmc_host *host) >> ret = host->bus_ops->reset(host); >> mmc_bus_put(host); >> >> - pr_warn("%s: tried to reset card\n", mmc_hostname(host)); >> + if (ret != -EOPNOTSUPP) >> + pr_warn("%s: tried to reset card\n", mmc_hostname(host)); > > Guess you don't want this message either if ret is zero. Thanks for your comment. I assumed the original author wants to see the message whenever reset is attempted, which is OK by me because it is on the recovery path i.e. hopefully rare. The EOPNOTSUPP case is consistent with the code further up which returns EOPNOTSUPP when there is no ->reset() callback.