From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: NeilBrown <neilb@suse.de>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: pwrseq_simple: fix error path in mmc_pwrseq_simple_alloc.
Date: Mon, 23 Feb 2015 09:27:36 +0100 [thread overview]
Message-ID: <54EAE478.4040309@collabora.co.uk> (raw)
In-Reply-To: <20150221151516.1b3bc8ae@notabene.brown>
Hello Neil,
On 02/21/2015 05:15 AM, NeilBrown wrote:
>
> From: NeilBrown <neil@brown.name>
>
> The current error-path code (when gpiod_get_index() reports
> an error) can never free pwrseq->reset_gpios[0], but might
> try to tree pwrseq->reset_gpios[-1], which has unfortunate
> consequences.
>
> Signed-off-by: NeilBrown <neil@brown.name>
> Fixes: 934f1f48330ed695927a51fa068dc5d673f2da19
>
>
Right, sorry for the silly mistake.
Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2015-02-23 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 4:15 [PATCH] mmc: pwrseq_simple: fix error path in mmc_pwrseq_simple_alloc NeilBrown
2015-02-23 8:27 ` Javier Martinez Canillas [this message]
2015-03-05 14:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EAE478.4040309@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=neilb@suse.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox