From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH v5 05/12] mmc: sdhci-msm: Add get_min_clock() and get_max_clock() callback Date: Mon, 10 Oct 2016 12:46:50 +0300 Message-ID: <54b602df-9c23-dc81-fd51-d04b441b99c0@intel.com> References: <1475678440-3525-1-git-send-email-riteshh@codeaurora.org> <1475678440-3525-6-git-send-email-riteshh@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com ([134.134.136.65]:46359 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751765AbcJJJvm (ORCPT ); Mon, 10 Oct 2016 05:51:42 -0400 In-Reply-To: <1475678440-3525-6-git-send-email-riteshh@codeaurora.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ritesh Harjani , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, shawn.lin@rock-chips.com Cc: david.brown@linaro.org, andy.gross@linaro.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, alex.lemberg@sandisk.com, mateusz.nowak@intel.com, Yuliy.Izrailov@sandisk.com, asutoshd@codeaurora.org, david.griego@linaro.org, stummala@codeaurora.org, venkatg@codeaurora.org, sboyd@codeaurora.org, bjorn.andersson@linaro.org, pramod.gurav@linaro.org On 05/10/16 17:40, Ritesh Harjani wrote: > This add get_min_clock() and get_max_clock() callback > for sdhci-msm. sdhci-msm min/max clocks may be different > hence implement these callbacks. > > Signed-off-by: Sahitya Tummala > Signed-off-by: Ritesh Harjani > --- > drivers/mmc/host/sdhci-msm.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 042ecb2..4e17201 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -68,6 +68,7 @@ > #define CORE_VENDOR_SPEC_CAPABILITIES0 0x11c > > #define TCXO_FREQ 19200000 > +#define SDHCI_MSM_MIN_CLOCK 400000 > > #define CDR_SELEXT_SHIFT 20 > #define CDR_SELEXT_MASK (0xf << CDR_SELEXT_SHIFT) > @@ -561,6 +562,32 @@ static irqreturn_t sdhci_msm_pwr_irq(int irq, void *data) > return IRQ_HANDLED; > } > > +static unsigned int sdhci_msm_get_max_clock(struct sdhci_host *host) > +{ > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); > + int count; > + > + if (msm_host->clk_table) { I don't know if DT allows empty arrays, but if it does, might not msm_host->clk_table_sz be zero here. > + count = msm_host->clk_table_sz; > + return msm_host->clk_table[count - 1]; > + } else { 'else' is redundant here. > + return clk_round_rate(msm_host->clk, ULONG_MAX); > + } > +} > + > +static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host) > +{ > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > + struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host); > + > + if (msm_host->clk_table) { Same about possibility of msm_host->clk_table_sz being zero. > + return msm_host->clk_table[0]; > + } else { 'else' is redundant here. > + return SDHCI_MSM_MIN_CLOCK; > + } > +} > + > static const struct of_device_id sdhci_msm_dt_match[] = { > { .compatible = "qcom,sdhci-msm-v4" }, > {}, > @@ -572,6 +599,8 @@ static const struct sdhci_ops sdhci_msm_ops = { > .platform_execute_tuning = sdhci_msm_execute_tuning, > .reset = sdhci_reset, > .set_clock = sdhci_set_clock, > + .get_min_clock = sdhci_msm_get_min_clock, > + .get_max_clock = sdhci_msm_get_max_clock, > .set_bus_width = sdhci_set_bus_width, > .set_uhs_signaling = sdhci_msm_set_uhs_signaling, > .voltage_switch = sdhci_msm_voltage_switch, >