* [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
[not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk>
@ 2015-03-18 15:53 ` Ben Dooks
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ben Dooks @ 2015-03-18 15:53 UTC (permalink / raw)
To: linux-kernel, linux-arm-kernel
Cc: Ben Dooks, Ludovic Desroches, Chris Ball, Ulf Hansson, linux-mmc
Change the __raw IO functions to endian agnostic relaxed ones to allow
the driver to function on big endian ARM systems.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
--
CC: Ludovic Desroches <ludovic.desroches@atmel.com>
CC: Chris Ball <chris@printf.net>
CC: Ulf Hansson <ulf.hansson@linaro.org>
CC: linux-mmc@vger.kernel.org
---
drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
index c97001e..711bb53 100644
--- a/drivers/mmc/host/atmel-mci-regs.h
+++ b/drivers/mmc/host/atmel-mci-regs.h
@@ -135,10 +135,17 @@
#define ATMCI_REGS_SIZE 0x100
/* Register access macros */
-#define atmci_readl(port,reg) \
+#ifdef CONFIG_AVR32
+#define atmci_readl(port,reg) \
__raw_readl((port)->regs + reg)
#define atmci_writel(port,reg,value) \
__raw_writel((value), (port)->regs + reg)
+#else
+#define atmci_readl(port,reg) \
+ readl_relaxed((port)->regs + reg)
+#define atmci_writel(port,reg,value) \
+ writel_relaxed((value), (port)->regs + reg)
+#endif
/* On AVR chips the Peripheral DMA Controller is not connected to MCI. */
#ifdef CONFIG_AVR32
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Linux-kernel] [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
2015-03-18 15:53 ` [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO Ben Dooks
@ 2015-03-19 14:22 ` Ben Hutchings
2015-03-24 12:53 ` Ben Dooks
2015-03-24 14:08 ` Ludovic Desroches
2015-03-25 8:52 ` Ulf Hansson
2 siblings, 1 reply; 6+ messages in thread
From: Ben Hutchings @ 2015-03-19 14:22 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, linux-arm-kernel, Ulf Hansson, linux-mmc,
Chris Ball, Ludovic Desroches
On Wed, 2015-03-18 at 15:53 +0000, Ben Dooks wrote:
> Change the __raw IO functions to endian agnostic relaxed ones to allow
> the driver to function on big endian ARM systems.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> --
> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
> CC: Chris Ball <chris@printf.net>
> CC: Ulf Hansson <ulf.hansson@linaro.org>
> CC: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
> index c97001e..711bb53 100644
> --- a/drivers/mmc/host/atmel-mci-regs.h
> +++ b/drivers/mmc/host/atmel-mci-regs.h
> @@ -135,10 +135,17 @@
> #define ATMCI_REGS_SIZE 0x100
>
> /* Register access macros */
> -#define atmci_readl(port,reg) \
> +#ifdef CONFIG_AVR32
> +#define atmci_readl(port,reg) \
> __raw_readl((port)->regs + reg)
> #define atmci_writel(port,reg,value) \
> __raw_writel((value), (port)->regs + reg)
> +#else
> +#define atmci_readl(port,reg) \
> + readl_relaxed((port)->regs + reg)
> +#define atmci_writel(port,reg,value) \
> + writel_relaxed((value), (port)->regs + reg)
> +#endif
This pattern is repeated in a lot of drivers; is it worth defining
atmel_{read,write}l_relaxed() in a common header?
#ifdef CONFIG_AVR32
/* CPU and peripherals are both big-endian, so don't byte-swap */
#define atmel_readl_relaxed(addr) __raw_readl(addr)
#define atmel_writel_relaxed(value, addr) __raw_writel(value, addr)
#else
/* Peripherals are little-endian, so byte-swap if CPU isn't */
#define atmel_readl_relaxed(addr) readl_relaxed(addr)
#define atmel_writel_relaxed(value, addr) writel_relaxed(value, addr)
#endif
Ben.
> /* On AVR chips the Peripheral DMA Controller is not connected to MCI. */
> #ifdef CONFIG_AVR32
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel] [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
@ 2015-03-24 12:53 ` Ben Dooks
2015-03-25 6:14 ` Hans-Christian Egtvedt
0 siblings, 1 reply; 6+ messages in thread
From: Ben Dooks @ 2015-03-24 12:53 UTC (permalink / raw)
To: Ben Hutchings
Cc: linux-kernel, linux-arm-kernel, Ulf Hansson, linux-mmc,
Chris Ball, Ludovic Desroches, Haavard Skinnemoen,
Hans-Christian Egtvedt
On 19/03/15 14:22, Ben Hutchings wrote:
> On Wed, 2015-03-18 at 15:53 +0000, Ben Dooks wrote:
>> Change the __raw IO functions to endian agnostic relaxed ones to allow
>> the driver to function on big endian ARM systems.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> --
>> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
>> CC: Chris Ball <chris@printf.net>
>> CC: Ulf Hansson <ulf.hansson@linaro.org>
>> CC: linux-mmc@vger.kernel.org
>> ---
>> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
>> index c97001e..711bb53 100644
>> --- a/drivers/mmc/host/atmel-mci-regs.h
>> +++ b/drivers/mmc/host/atmel-mci-regs.h
>> @@ -135,10 +135,17 @@
>> #define ATMCI_REGS_SIZE 0x100
>>
>> /* Register access macros */
>> -#define atmci_readl(port,reg) \
>> +#ifdef CONFIG_AVR32
>> +#define atmci_readl(port,reg) \
>> __raw_readl((port)->regs + reg)
>> #define atmci_writel(port,reg,value) \
>> __raw_writel((value), (port)->regs + reg)
>> +#else
>> +#define atmci_readl(port,reg) \
>> + readl_relaxed((port)->regs + reg)
>> +#define atmci_writel(port,reg,value) \
>> + writel_relaxed((value), (port)->regs + reg)
>> +#endif
>
> This pattern is repeated in a lot of drivers; is it worth defining
> atmel_{read,write}l_relaxed() in a common header?
>
> #ifdef CONFIG_AVR32
>
> /* CPU and peripherals are both big-endian, so don't byte-swap */
> #define atmel_readl_relaxed(addr) __raw_readl(addr)
> #define atmel_writel_relaxed(value, addr) __raw_writel(value, addr)
>
> #else
>
> /* Peripherals are little-endian, so byte-swap if CPU isn't */
> #define atmel_readl_relaxed(addr) readl_relaxed(addr)
> #define atmel_writel_relaxed(value, addr) writel_relaxed(value, addr)
>
> #endif
>
> Ben.
Hi, I think it will probably be a good idea to have an avr32/at91
read/write functions however I will put this forward as a separate
series as it will require both avr32 and at91 maintainers as well
as driver updates.
how about:
atmel_readl_onchip{b,w,l}
atmel_writel_onchip{b,w,l}
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
2015-03-18 15:53 ` [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO Ben Dooks
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
@ 2015-03-24 14:08 ` Ludovic Desroches
2015-03-25 8:52 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Ludovic Desroches @ 2015-03-24 14:08 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, linux-arm-kernel, Ludovic Desroches, Chris Ball,
Ulf Hansson, linux-mmc
On Wed, Mar 18, 2015 at 03:53:11PM +0000, Ben Dooks wrote:
> Change the __raw IO functions to endian agnostic relaxed ones to allow
> the driver to function on big endian ARM systems.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> --
> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
> CC: Chris Ball <chris@printf.net>
> CC: Ulf Hansson <ulf.hansson@linaro.org>
> CC: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
> index c97001e..711bb53 100644
> --- a/drivers/mmc/host/atmel-mci-regs.h
> +++ b/drivers/mmc/host/atmel-mci-regs.h
> @@ -135,10 +135,17 @@
> #define ATMCI_REGS_SIZE 0x100
>
> /* Register access macros */
> -#define atmci_readl(port,reg) \
> +#ifdef CONFIG_AVR32
> +#define atmci_readl(port,reg) \
> __raw_readl((port)->regs + reg)
> #define atmci_writel(port,reg,value) \
> __raw_writel((value), (port)->regs + reg)
> +#else
> +#define atmci_readl(port,reg) \
> + readl_relaxed((port)->regs + reg)
> +#define atmci_writel(port,reg,value) \
> + writel_relaxed((value), (port)->regs + reg)
> +#endif
>
> /* On AVR chips the Peripheral DMA Controller is not connected to MCI. */
> #ifdef CONFIG_AVR32
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel] [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
2015-03-24 12:53 ` Ben Dooks
@ 2015-03-25 6:14 ` Hans-Christian Egtvedt
0 siblings, 0 replies; 6+ messages in thread
From: Hans-Christian Egtvedt @ 2015-03-25 6:14 UTC (permalink / raw)
To: Ben Dooks
Cc: Ben Hutchings, linux-kernel, linux-arm-kernel, Ulf Hansson,
linux-mmc, Chris Ball, Ludovic Desroches, Haavard Skinnemoen
Around Tue 24 Mar 2015 12:53:41 +0000 or thereabout, Ben Dooks wrote:
> On 19/03/15 14:22, Ben Hutchings wrote:
>> On Wed, 2015-03-18 at 15:53 +0000, Ben Dooks wrote:
>>> Change the __raw IO functions to endian agnostic relaxed ones to allow
>>> the driver to function on big endian ARM systems.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> --
>>> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
>>> CC: Chris Ball <chris@printf.net>
>>> CC: Ulf Hansson <ulf.hansson@linaro.org>
>>> CC: linux-mmc@vger.kernel.org
>>> ---
>>> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
>>> index c97001e..711bb53 100644
>>> --- a/drivers/mmc/host/atmel-mci-regs.h
>>> +++ b/drivers/mmc/host/atmel-mci-regs.h
>>> @@ -135,10 +135,17 @@
>>> #define ATMCI_REGS_SIZE 0x100
>>>
>>> /* Register access macros */
>>> -#define atmci_readl(port,reg) \
>>> +#ifdef CONFIG_AVR32
>>> +#define atmci_readl(port,reg) \
>>> __raw_readl((port)->regs + reg)
>>> #define atmci_writel(port,reg,value) \
>>> __raw_writel((value), (port)->regs + reg)
>>> +#else
>>> +#define atmci_readl(port,reg) \
>>> + readl_relaxed((port)->regs + reg)
>>> +#define atmci_writel(port,reg,value) \
>>> + writel_relaxed((value), (port)->regs + reg)
>>> +#endif
>>
>> This pattern is repeated in a lot of drivers; is it worth defining
>> atmel_{read,write}l_relaxed() in a common header?
>>
>> #ifdef CONFIG_AVR32
>>
>> /* CPU and peripherals are both big-endian, so don't byte-swap */
>> #define atmel_readl_relaxed(addr) __raw_readl(addr)
>> #define atmel_writel_relaxed(value, addr) __raw_writel(value, addr)
>>
>> #else
>>
>> /* Peripherals are little-endian, so byte-swap if CPU isn't */
>> #define atmel_readl_relaxed(addr) readl_relaxed(addr)
>> #define atmel_writel_relaxed(value, addr) writel_relaxed(value, addr)
>>
>> #endif
>>
>> Ben.
>
> Hi, I think it will probably be a good idea to have an avr32/at91
> read/write functions however I will put this forward as a separate
> series as it will require both avr32 and at91 maintainers as well
> as driver updates.
>
> how about:
> atmel_readl_onchip{b,w,l}
> atmel_writel_onchip{b,w,l}
Common is good, will make it easier for developers to understand why it is
like this as well.
--
Hans-Christian Egtvedt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO
2015-03-18 15:53 ` [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO Ben Dooks
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
2015-03-24 14:08 ` Ludovic Desroches
@ 2015-03-25 8:52 ` Ulf Hansson
2 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2015-03-25 8:52 UTC (permalink / raw)
To: Ben Dooks
Cc: linux-kernel, linux-arm-kernel@lists.infradead.org,
Ludovic Desroches, Chris Ball, linux-mmc
On 18 March 2015 at 16:53, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Change the __raw IO functions to endian agnostic relaxed ones to allow
> the driver to function on big endian ARM systems.
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Thanks! Applied.
Kind regards
Uffe
> --
> CC: Ludovic Desroches <ludovic.desroches@atmel.com>
> CC: Chris Ball <chris@printf.net>
> CC: Ulf Hansson <ulf.hansson@linaro.org>
> CC: linux-mmc@vger.kernel.org
> ---
> drivers/mmc/host/atmel-mci-regs.h | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci-regs.h b/drivers/mmc/host/atmel-mci-regs.h
> index c97001e..711bb53 100644
> --- a/drivers/mmc/host/atmel-mci-regs.h
> +++ b/drivers/mmc/host/atmel-mci-regs.h
> @@ -135,10 +135,17 @@
> #define ATMCI_REGS_SIZE 0x100
>
> /* Register access macros */
> -#define atmci_readl(port,reg) \
> +#ifdef CONFIG_AVR32
> +#define atmci_readl(port,reg) \
> __raw_readl((port)->regs + reg)
> #define atmci_writel(port,reg,value) \
> __raw_writel((value), (port)->regs + reg)
> +#else
> +#define atmci_readl(port,reg) \
> + readl_relaxed((port)->regs + reg)
> +#define atmci_writel(port,reg,value) \
> + writel_relaxed((value), (port)->regs + reg)
> +#endif
>
> /* On AVR chips the Peripheral DMA Controller is not connected to MCI. */
> #ifdef CONFIG_AVR32
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-25 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1426693992-31163-1-git-send-email-ben.dooks@codethink.co.uk>
2015-03-18 15:53 ` [PATCH 12/13] mmc: atmel-mci: use endian agnostic IO Ben Dooks
2015-03-19 14:22 ` [Linux-kernel] " Ben Hutchings
2015-03-24 12:53 ` Ben Dooks
2015-03-25 6:14 ` Hans-Christian Egtvedt
2015-03-24 14:08 ` Ludovic Desroches
2015-03-25 8:52 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox