From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host Date: Wed, 16 Jul 2014 11:53:21 +0200 Message-ID: <5513748.05vsM1lCJN@avalon> References: <1405497009-20338-1-git-send-email-wangxfdu@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1405497009-20338-1-git-send-email-wangxfdu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Xiang Wang , Xiang Wang Cc: Chris Ball , Ulf Hansson , Marcin Wojtas , H Hartley Sweeten , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Xie List-Id: linux-mmc@vger.kernel.org Hi Xiang, Thank you for the patch. On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote: > From: Xiang Wang > > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error > handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req" > should be placed after "pm_runtime_disable(&pdev->dev)". > > Signed-off-by: Xiang Wang Acked-by: Laurent Pinchart While we're touching the probe error path, how about converting the driver to the devm_* helpers ? I'll send a patch shortly. > --- > drivers/mmc/host/sdhci-pxav3.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > index 2fd73b3..0644655 100644 > --- a/drivers/mmc/host/sdhci-pxav3.c > +++ b/drivers/mmc/host/sdhci-pxav3.c > @@ -380,11 +380,11 @@ static int sdhci_pxav3_probe(struct platform_device > *pdev) > > return 0; > > -err_of_parse: > -err_cd_req: > err_add_host: > pm_runtime_put_sync(&pdev->dev); > pm_runtime_disable(&pdev->dev); > +err_of_parse: > +err_cd_req: > clk_disable_unprepare(clk); > clk_put(clk); > err_clk_get: -- Regards, Laurent Pinchart