Re: [PATCH] mmc: core: Cleanup unused OF nodes while parsing for child nodes

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 30-03-15 11:19, Ulf Hansson wrote:
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>   drivers/mmc/core/core.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index c296bc0..e6b0bdb 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1291,6 +1291,8 @@ struct device_node *mmc_of_find_child_device(struct mmc_host *host,
>   	for_each_child_of_node(host->parent->of_node, node) {
>   		if (mmc_of_get_func_num(node) == func_num)
>   			return node;
> +		else
> +			of_node_put(node);
>   	}
>
>   	return NULL;
>

I don't think this is right, non of the other users of for_each_child_of_node
do this, I think that rather then doing this we should be changing the callers
of mmc_of_find_child_device to do: of_node_get(), except for the call which
my "mmc: Add support for marking hpi as broken through devicetree" patch adds,
as that is intended to only take a temporary reference.

Regards,

Hans