04e079cf6b24c794 to stable

04e079cf6b24c794 to stable

[Fabio Estevam]

Hi Ulf and Scott,

Should the commit below be applied to stable?

commit 04e079cf6b24c794bbc52b04b370f84cb728540e
Author: Scott Branden <sbranden@broadcom.com>
Date:   Tue Mar 10 11:35:10 2015 -0700

    mmc: sdhci: fix card presence logic in sdhci_request function

    The sdhci_request function should consider a non-removable device
    always present.
    Call the correct logic already available in sdhci_do_get_cd function.

    This fixes some logic paths where MMC requests are being made to
    non-removable devices that do not have the card detect pin connected
    on the hardware as it is non-removable.

    Signed-off-by: Scott Branden <sbranden@broadcom.com>
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

The reason I am asking is that we were seeing issues on mx6 boards
running 4.0 kernel branch + 8d86e4fcccf61bafe5 ("mmc: sdhci-esdhc-imx:
Call mmc_of_parse()"), which is 4.1-rc1 material.

Otavio suggested me to apply 04e079cf6b24 in our tree and after that
the SD card detection goes away.

If you agree I can submit it to stable. Please let me know.

Regards,

Fabio Estevam

Re: 04e079cf6b24c794 to stable

[Fabio Estevam]

On Tue, Apr 28, 2015 at 12:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Ulf and Scott,
>
> Should the commit below be applied to stable?
>
> commit 04e079cf6b24c794bbc52b04b370f84cb728540e
> Author: Scott Branden <sbranden@broadcom.com>
> Date:   Tue Mar 10 11:35:10 2015 -0700
>
>     mmc: sdhci: fix card presence logic in sdhci_request function
>
>     The sdhci_request function should consider a non-removable device
>     always present.
>     Call the correct logic already available in sdhci_do_get_cd function.
>
>     This fixes some logic paths where MMC requests are being made to
>     non-removable devices that do not have the card detect pin connected
>     on the hardware as it is non-removable.
>
>     Signed-off-by: Scott Branden <sbranden@broadcom.com>
>     Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> The reason I am asking is that we were seeing issues on mx6 boards
> running 4.0 kernel branch + 8d86e4fcccf61bafe5 ("mmc: sdhci-esdhc-imx:
> Call mmc_of_parse()"), which is 4.1-rc1 material.
>
> Otavio suggested me to apply 04e079cf6b24 in our tree and after that
> the SD card detection goes away.

Sorry, I meant "and after that the SD card detection problem goes away"

Re: 04e079cf6b24c794 to stable

[Scott Branden]

Hi Fabio,

Yes, you can apply the change to stable.

Regards,
Scott

On 15-04-28 12:49 PM, Fabio Estevam wrote:
> On Tue, Apr 28, 2015 at 12:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> Hi Ulf and Scott,
>>
>> Should the commit below be applied to stable?
>>
>> commit 04e079cf6b24c794bbc52b04b370f84cb728540e
>> Author: Scott Branden <sbranden@broadcom.com>
>> Date:   Tue Mar 10 11:35:10 2015 -0700
>>
>>      mmc: sdhci: fix card presence logic in sdhci_request function
>>
>>      The sdhci_request function should consider a non-removable device
>>      always present.
>>      Call the correct logic already available in sdhci_do_get_cd function.
>>
>>      This fixes some logic paths where MMC requests are being made to
>>      non-removable devices that do not have the card detect pin connected
>>      on the hardware as it is non-removable.
>>
>>      Signed-off-by: Scott Branden <sbranden@broadcom.com>
>>      Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>
>> The reason I am asking is that we were seeing issues on mx6 boards
>> running 4.0 kernel branch + 8d86e4fcccf61bafe5 ("mmc: sdhci-esdhc-imx:
>> Call mmc_of_parse()"), which is 4.1-rc1 material.
>>
>> Otavio suggested me to apply 04e079cf6b24 in our tree and after that
>> the SD card detection goes away.
>
> Sorry, I meant "and after that the SD card detection problem goes away"
>