Re: [RFC PATCH 4/7] ARM: shmobile: r8a7790: Add nodes for pfc SD voltage regulators

Simon Horman
2015-05-07T04:33:10Z

On Wed, May 06, 2015 at 02:18:02AM +0100, Ben Hutchings wrote:
> On Fri, 2015-05-01 at 09:57 +0900, Simon Horman wrote:
> > Hi Ben,
> >
> > thanks for your patch-set.
> >
> > On Thu, Apr 30, 2015 at 01:31:54PM +0100, Ben Hutchings wrote:
> > > Signed-off-by: Ben Hutchings <ben.hutchings-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
> > > ---
> > > arch/arm/boot/dts/r8a7790.dtsi | 21 +++++++++++++++++++++
> > > 1 file changed, 21 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > > index 4bb2f4c17321..23e826153a9d 100644
> > > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > > @@ -483,6 +483,23 @@
> > > pfc: pfc@e6060000 {
> > > compatible = "renesas,pfc-r8a7790";
> > > reg = <0 0xe6060000 0 0x250>;
> > > +
> > > + vccq_ref_sdhi0: sd-regulator@0 {
> > > + compatible = "renesas,pfc-r8a7790-sd-regulator";
> >
> > I'm a little confused. What is "renesas,pfc-r8a7790-sd-regulator"?
> > It suspect that it should at least be documented under
> > Documentation/devicetree/bindings/
> [...]
>
> It will be if it's agreed that this is the way to represent the voltage
> switch in the pfc. The sh-pfc driver is changed in patch 3/7 to look
> for sd-regulator@{0..3} nodes in an r8a7790 DT. The nodes carry only
> their address and status. The compatible value is currently ignored.

Thanks, that makes sense.

As a rule I generally don't apply DT patches that use bindings
that haven't already been accepted. So if this does turn out to
be the way to go then please document it.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html