Re: [PATCH 1/3] Document: dw_mmc-k3: add document of hi6220 mmc

[Jaehoon Chung <jh80.chung@samsung.com>]

Hi, Zhangfei.

Is there no commit message for this patch?

On 05/01/2015 10:46 AM, Zhangfei Gao wrote:
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>  .../devicetree/bindings/mmc/k3-dw-mshc.txt         | 50 ++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
> index 3b35449..a353d0b 100644
> --- a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
> +++ b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
> @@ -13,6 +13,10 @@ Required Properties:
>  
>  * compatible: should be one of the following.
>    - "hisilicon,hi4511-dw-mshc": for controllers with hi4511 specific extensions.
> +  - "hisilicon,hi6220-dw-mshc": for controllers with hi6220 specific extensions.
> +
> +Optional Properties:
> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
>  
>  Example:
>  
> @@ -42,3 +46,49 @@ Example:
>  		cap-mmc-highspeed;
>  		cap-sd-highspeed;
>  	};
> +
> +	/* for Hi6220 */
> +
> +	/* SoC portion */
> +	dwmmc_0: dwmmc0@f723d000 {
> +	        compatible = "hisilicon,hi6220-dw-mshc";
> +	        num-slots = <0x1>;
> +	        board-mmc-bus-clk = <0x0>;
> +	        reg = <0x0 0xf723d000 0x0 0x1000>;
> +	        interrupts = <0x0 0x48 0x4>;
> +	        clocks = <&clock_sys HI6220_MMC0_CIUCLK>, <&clock_sys HI6220_MMC0_CLK>;
> +	        clock-names = "ciu", "biu";
> +	};
> +
> +	dwmmc_1: dwmmc1@f723e000 {
> +		compatible = "hisilicon,hi6220-dw-mshc";
> +		num-slots = <0x1>;
> +		board-mmc-bus-clk = <0x0>;
> +		card-detect-delay = <200>;
> +		hisilicon,peripheral-syscon = <&ao_ctrl>;
> +		reg = <0x0 0xf723e000 0x0 0x1000>;
> +		interrupts = <0x0 0x49 0x4>;
> +		clocks = <&clock_sys HI6220_MMC1_CIUCLK>, <&clock_sys HI6220_MMC1_CLK>;
> +		clock-names = "ciu", "biu";
> +	};

this is example, so i think it doesn't need to add dwmmc_1's case.

> +
> +	/* Board portion */

What are Board portion and SoC portion?
This should be merged to one node. why do you separate this?

Best Regards,
Jaehoon Chung
> +	dwmmc_0: dwmmc0@f723d000 {
> +		bus-width = <0x8>;
> +	        broken-cd;
> +		vmmc-supply = <&ldo19>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&emmc_pmx_func &emmc_clk_cfg_func
> +			     &emmc_cfg_func &emmc_rst_cfg_func>;
> +	};
> +
> +	dwmmc_1: dwmmc1@f723e000 {
> +		bus-width = <0x4>;
> +		disable-wp;
> +		cd-gpios = <&gpio1 0 1>;
> +		pinctrl-names = "default", "idle";
> +		pinctrl-0 = <&sd_pmx_func &sd_clk_cfg_func &sd_cfg_func>;
> +		pinctrl-1 = <&sd_pmx_idle &sd_clk_cfg_idle &sd_cfg_idle>;
> +		vqmmc-supply = <&ldo7>;
> +		vmmc-supply = <&ldo10>;
> +	};
>