From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangfei Subject: Re: [PATCH] mmc: dw_mmc: dw_mci_get_cd check MMC_CAP_NONREMOVABLE Date: Wed, 06 May 2015 09:33:44 +0800 Message-ID: <55496F78.3080700@linaro.org> References: <1430816089-8857-1-git-send-email-zhangfei.gao@linaro.org> <55496227.9000904@samsung.com> <55496DC8.8060208@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pd0-f174.google.com ([209.85.192.174]:35968 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbbEFBdv (ORCPT ); Tue, 5 May 2015 21:33:51 -0400 Received: by pdea3 with SMTP id a3so215185904pde.3 for ; Tue, 05 May 2015 18:33:50 -0700 (PDT) In-Reply-To: <55496DC8.8060208@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jaehoon Chung Cc: "linux-mmc@vger.kernel.org" On 05/06/2015 09:26 AM, Jaehoon Chung wrote: > Hi, > > On 05/06/2015 10:14 AM, Zhangfei Gao wrote: >> On 6 May 2015 at 08:36, Jaehoon Chung wrote: >>> Hi, Zhangfei. >>> >>> If you want to check it, use the "broken-cd" and "non-removable" properties into dt-file. >>> Did you use them? >> >> Yes. >> "broken-cd" can work, but mmc_rescan keeps running. >> "non-removable" does NOT work, which should be used for emmc. >> Since dw_mci_get_cd only checks DW_MCI_QUIRK_BROKEN_CARD_DETECTION, so >> only checks "broken-cd" but not check "non-removable" > > Did you use the usage like the below.. > > dwmmc0 { > non-removable; > broken-cd; > }; non-removable and broken-cd should be used only one. Documentation/devicetree/bindings/mmc/mmc.txt Card detection: If no property below is supplied, host native card detect is used. Only one of the properties in this section should be supplied: - broken-cd: There is no card detection available; polling must be used. - cd-gpios: Specify GPIOs for card detection, see gpio binding - non-removable: non-removable slot (like eMMC); assume always present. work dwmmc0 { broken-cd; }; NOT work dwmmc0 { non-removable; }; Thanks