public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Dorfman <kdorfman@codeaurora.org>
To: Meng Wang <meng@tupleapes.com>, linux-mmc@vger.kernel.org
Subject: Re: execution order of packed command in eMMC
Date: Thu, 07 May 2015 10:02:00 +0300	[thread overview]
Message-ID: <554B0DE8.5000806@codeaurora.org> (raw)
In-Reply-To: <CAP3VVE1idbQ2fLw1wpEBnuJiprGa0L46OuzR_Ng6zc_yxyfcRg@mail.gmail.com>

Hello,

On 05/06/2015 09:16 PM, Meng Wang wrote:
> sequence that they are listed in the packed command header. So when
> error happens, I can safely assert it is completed for the first
> PACKED_FAILURE_INDEX commands in one pack. Is my understanding
> correct?

Yes, mmc_blk_end_packed_req() will complete packed requests till 
idx_failure index.

 From mmc_blk_issue_rw_rq():

case MMC_BLK_PARTIAL:
			/*
			 * A block was successfully transferred.
			 */
			mmc_blk_reset_success(md, type);

			if (mmc_packed_cmd(mq_rq->cmd_type)) {
				ret = mmc_blk_end_packed_req(mq_rq);
				break;
			} else {
				ret = blk_end_request(req, 0,
						brq->data.bytes_xfered);
			}

Then, reminder will be re-issued with mmc_start_req():

...
		if (ret) {
			if (mmc_packed_cmd(mq_rq->cmd_type)) {
				if (!mq_rq->packed->retries)
					goto cmd_abort;
				mmc_blk_packed_hdr_wrq_prep(mq_rq, card, mq);
				mmc_start_req(card->host,
					      &mq_rq->mmc_active, NULL);


-- 
Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-05-07  7:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 18:16 execution order of packed command in eMMC Meng Wang
2015-05-07  7:02 ` Konstantin Dorfman [this message]
2015-05-07 14:38   ` Meng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=554B0DE8.5000806@codeaurora.org \
    --to=kdorfman@codeaurora.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=meng@tupleapes.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox