Re: [PATCH v2 1/3] Document: dw_mmc-k3: add document of hi6220 mmc

[Jaehoon Chung <jh80.chung@samsung.com>]

On 05/12/2015 04:59 PM, zhangfei wrote:
> 
> 
> On 05/12/2015 03:36 PM, Jaehoon Chung wrote:
>> Hi, Zhangfei.
>>
>> On 05/07/2015 04:56 PM, Zhangfei Gao wrote:
>>> Add bindings for hi6220 mmc support
>>>
>>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>>> ---
>>>   .../devicetree/bindings/mmc/k3-dw-mshc.txt         | 28 ++++++++++++++++++++++
>>>   1 file changed, 28 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
>>> index 3b35449..df37058 100644
>>> --- a/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt
>>> @@ -13,6 +13,10 @@ Required Properties:
>>>
>>>   * compatible: should be one of the following.
>>>     - "hisilicon,hi4511-dw-mshc": for controllers with hi4511 specific extensions.
>>> +  - "hisilicon,hi6220-dw-mshc": for controllers with hi6220 specific extensions.
>>> +
>>> +Optional Properties:
>>> +- hisilicon,peripheral-syscon: phandle of syscon used to control peripheral.
>>>
>> I'm not sure..
>> but i think this patch could be added just the compatible and optional properties descriptions.
>> If SoC will be added, it need not to add every example, doesn't it?
>>
>> how about removing the below example? This is just my opinion. :)
>> If there is a special reason that add example...let me know, plz.
> 
> I am adding this example just for two reasons
> 
> 1. There is still some components need to be upstreamed before we add to dts, like pinctrl and regulator, which still need some time.
> So add here for quick reference after the component is enabled.
> Had experience before that hip04_eth is merged but dts is delayed, thanks to the document, we can add it quickly.
> 
> 2. sd has some special requirement of "hisilicon,peripheral-syscon", which used for controlling voltage
> 
> 
> What do you think?

Thanks for kindly explanation! I understood your intention.

Best Regards,
Jaehoon Chung

> 
> Thanks
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>