From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text
Date: Wed, 12 Aug 2015 13:41:40 +0300 [thread overview]
Message-ID: <55CB22E4.5040904@cogentembedded.com> (raw)
In-Reply-To: <20150812005628.GE15957@verge.net.au>
On 8/12/2015 3:56 AM, Simon Horman wrote:
>> The "compatible" property text contradicts even the example given in the MMCIF
>> binding document itself; moreover, the Renesas MMCIF driver only matches on
>> the generic "compatible" string and doesn't look for the SoC specific strings
>> at all. Thus describe "renesas,sh-mmcif" as a fallback value.
>> Fixes: b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> I don't believe this file is the appropriate place to describe
> best-practice for the ordering of compatible strings which must surely be
> documented elsewhere.
Where? I have no idea what you mean...
And let me reiterate: this text is *wrong* and needs to be fixed anyway.
>> ---
>> The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.
>>
>> Changes in version 2:
>> - kept the SoC specific "compatible" property values mandatory and made the
>> generic string a fallback.
>>
>> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Index: mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
>> ===================================================================
>> --- mmc.orig/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
>> +++ mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
>> @@ -10,7 +10,7 @@ Required properties:
>> - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>> - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>> - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>> - - "renesas,sh-mmcif" for the generic MMCIF
>> + followed by "renesas,sh-mmcif".
>>
>> - clocks: reference to the functional clock
MBR, Sergei
next prev parent reply other threads:[~2015-08-12 10:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201404250239.39150.sergei.shtylyov@cogentembedded.com>
2015-07-30 19:59 ` [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov
2015-07-30 20:33 ` Sergei Shtylyov
2015-07-31 2:23 ` Magnus Damm
2015-08-01 9:41 ` Laurent Pinchart
[not found] ` <55BB44DC.8040706@cogentembedded.com>
2015-08-03 1:09 ` Magnus Damm
2015-07-30 21:29 ` [PATCH] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov
2015-08-11 22:37 ` [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov
2015-08-12 0:56 ` Simon Horman
2015-08-12 10:41 ` Sergei Shtylyov [this message]
2015-08-12 23:58 ` Simon Horman
2015-08-11 22:57 ` [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov
2015-08-12 0:59 ` Simon Horman
2015-08-12 10:38 ` Sergei Shtylyov
2015-08-12 23:59 ` Simon Horman
2015-08-13 9:27 ` Ulrich Hecht
2015-10-15 22:39 ` [PATCH v3] DT: mmc: sh_mmcif: fix "compatible" property text Sergei Shtylyov
2015-10-16 6:42 ` Geert Uytterhoeven
[not found] ` <2188985.g7lrY44qCa-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2015-10-16 13:07 ` Ulf Hansson
2015-10-15 22:40 ` [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support Sergei Shtylyov
2015-10-16 6:42 ` Geert Uytterhoeven
2015-10-16 13:07 ` Ulf Hansson
2015-10-20 20:19 ` Sergei Shtylyov
[not found] ` <5626A1CF.9050309-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2015-10-21 8:38 ` Ulf Hansson
2015-10-21 18:42 ` Sergei Shtylyov
2015-10-27 16:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB22E4.5040904@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).