public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Michal Simek
	<michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>,
	soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
	shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1
Date: Tue, 18 Aug 2015 07:40:47 +0800	[thread overview]
Message-ID: <55D270FF.5030309@rock-chips.com> (raw)
In-Reply-To: <55CAD499.5070701-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

Hi Ulf,

On 2015/8/12 13:07, Michal Simek wrote:
> +linux-mmc
>
> On 08/11/2015 04:53 PM, Michal Simek wrote:
>> On 08/11/2015 09:46 AM, Shawn Lin wrote:
>>> This patch adds the compatible string in sdhci-of-arasan.c to
>>> support sdhci-arasan5.1 version of controller. No documented
>>> controller IP version is found in the TRM, so we use ths version
>>> of command queueing engine integrated into this controller by arasan
>>> to specify our controller.
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>>>
>>> ---
>>>
>>> Changes in v1:
>>> - Remove redundant SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN for "arasan, sdhci-5.1" since
>>>    SDHCI will check "host->max_clk == 0" and let driver get it from host->ops->get_max_clock.
>>>
>>>   Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 2 +-
>>>   drivers/mmc/host/sdhci-of-arasan.c                     | 1 +
>>>   2 files changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> index 7e94903..da541c3 100644
>>> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
>>> @@ -9,7 +9,7 @@ Device Tree Bindings for the Arasan SDHCI Controller
>>>
>>>   Required Properties:
>>>     - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or
>>> -                'arasan,sdhci-4.9a'
>>> +                'arasan,sdhci-4.9a' or 'arasan,sdhci-5.1'
>>>     - reg: From mmc bindings: Register location and length.
>>>     - clocks: From clock bindings: Handles to clock inputs.
>>>     - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
>>> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
>>> index ef5a7d2..75379cb 100644
>>> --- a/drivers/mmc/host/sdhci-of-arasan.c
>>> +++ b/drivers/mmc/host/sdhci-of-arasan.c
>>> @@ -217,6 +217,7 @@ static int sdhci_arasan_remove(struct platform_device *pdev)
>>>
>>>   static const struct of_device_id sdhci_arasan_of_match[] = {
>>>   	{ .compatible = "arasan,sdhci-8.9a" },
>>> +	{ .compatible = "arasan,sdhci-5.1" },
>>>   	{ .compatible = "arasan,sdhci-4.9a" },
>>>   	{ }
>>>   };
>>>
>>
>> Acked-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>

Could you pull this patch into your repository?

>>
>> Thanks,
>> Michal
>>
>>
>
>
>
>


-- 
Shawn Lin

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-08-17 23:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1439279190-9556-1-git-send-email-shawn.lin@rock-chips.com>
     [not found] ` <55CA0C6F.7000002@xilinx.com>
2015-08-12  5:07   ` [RFC PATCH v1] mmc: sdhci-of-arasan: Add the support for sdhci-5.1 Michal Simek
     [not found]     ` <55CAD499.5070701-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-08-17 23:40       ` Shawn Lin [this message]
2015-08-25 12:07         ` Ulf Hansson
2015-08-11  7:57 Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D270FF.5030309@rock-chips.com \
    --to=shawn.lin-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
    --cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox