From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] mmc: host: use of_property_read_bool()
Date: Wed, 26 Aug 2015 00:49:56 +0300 [thread overview]
Message-ID: <55DCE304.7020001@cogentembedded.com> (raw)
In-Reply-To: <CAPDyKFqjUZv2950ekKTiJCdt5TZe-YXWaX+DWeRbbep_AURSmg@mail.gmail.com>
On 08/26/2015 12:19 AM, Ulf Hansson wrote:
>>>> Use more compact of_property_read_bool() calls instead of the
>>>> of_find_property()
>>>> calls.
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>>> Thanks, applied for next!
>>
>> Thanks to you! :-)
>>
>>> Next, time please run checkpatch to remove errors/warnings.
>>
>> Hum, I just did and the patch seems clean:
>>
>> [headless@wasted mmc]$ scripts/checkpatch.pl
>> patches/mmc-host-use-of_property_read_bool.patch
>> total: 0 errors, 0 warnings, 81 lines checked
>>
>> patches/mmc-host-use-of_property_read_bool.patch has no obvious style
>> problems and is ready for submission.
>>
>> What do you mean?
> WARNING: Possible unwrapped commit description (prefer a maximum 75
> chars per line)
> #12:
> Use more compact of_property_read_bool() calls instead of the of_find_property()
> total: 0 errors, 1 warnings, 81 lines checked
> I suspect we might use different versions of the checkpatch script.
> Mine is from 4.2rc7.
Tried several variants, the last one was in your repo's 'next' branch
(4.2-rc7 based). No warning. :-)
> No worries then!
> Kind regards
> Uffe
MBR, Sergei
prev parent reply other threads:[~2015-08-25 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 22:06 [PATCH v2] mmc: host: use of_property_read_bool() Sergei Shtylyov
2015-08-25 12:05 ` Ulf Hansson
2015-08-25 16:32 ` Sergei Shtylyov
2015-08-25 21:19 ` Ulf Hansson
2015-08-25 21:49 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCE304.7020001@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).