linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Yousong Zhou <yszhou4tech@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sd: Remove superfluous error code assignment
Date: Wed, 9 Sep 2015 21:29:16 +0200	[thread overview]
Message-ID: <55F0888C.3010502@redhat.com> (raw)
In-Reply-To: <1441816398-4330-1-git-send-email-yszhou4tech@gmail.com>

Hi All,

I requested yousong to send this set to further discuss it,
and hopefully get some fix for this in the kernel.

Yousong, I actually intended you to do a patch to the sunxi-mmc
code, rather then too the core. Ah well. Since we've this set
now lets see if people like it, it may help other cases
too I guess.

Regards,

Hans


On 09-09-15 18:33, Yousong Zhou wrote:
> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
> ---
>   drivers/mmc/core/sd.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index 4e7366a..e28ebf3 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -357,8 +357,6 @@ int mmc_sd_switch_hs(struct mmc_card *card)
>   	if (card->sw_caps.hs_max_dtr == 0)
>   		return 0;
>
> -	err = -EIO;
> -
>   	status = kmalloc(64, GFP_KERNEL);
>   	if (!status) {
>   		pr_err("%s: could not allocate a buffer for "
>

  parent reply	other threads:[~2015-09-09 19:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09 16:33 [PATCH 1/3] mmc: sd: Remove superfluous error code assignment Yousong Zhou
2015-09-09 16:33 ` [PATCH 2/3] mmc: sd: Allow calling sd mode switch with retries Yousong Zhou
2015-09-10  0:33   ` Shawn Lin
2015-09-10  3:02     ` Yousong Zhou
2015-09-16  2:36       ` Jaehoon Chung
2015-09-16  3:09         ` Yousong Zhou
2015-09-16  4:17           ` Jaehoon Chung
2015-09-17  8:29             ` Yousong Zhou
2015-09-09 16:33 ` [PATCH 3/3] mmc: sd: Retry switching to highspeed mode in case of error Yousong Zhou
2015-09-09 19:29 ` Hans de Goede [this message]
2015-09-15 11:34 ` [PATCH 1/3] mmc: sd: Remove superfluous error code assignment Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F0888C.3010502@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    --cc=yszhou4tech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).