From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Fu, Zhonghui" Subject: Re: [PATCH] mmc/sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously Date: Mon, 21 Sep 2015 14:53:40 +0800 Message-ID: <55FFA974.6060401@linux.intel.com> References: <55BF6843.4050502@linux.intel.com> <55D15718.9080107@linux.intel.com> <55D18479.50506@intel.com> <55DB34B9.40303@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga01.intel.com ([192.55.52.88]:18507 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754958AbbIUGyC (ORCPT ); Mon, 21 Sep 2015 02:54:02 -0400 In-Reply-To: <55DB34B9.40303@linux.intel.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Adrian Hunter , andriy.shevchenko@linux.intel.com Cc: Ulf Hansson , yunpeng.gao@intel.com, peter.griffin@linaro.org, linux-mmc , "linux-kernel@vger.kernel.org" On 2015/8/24 23:14, Fu, Zhonghui wrote: > > On 2015/8/17 14:51, Adrian Hunter wrote: >> On 17/08/15 06:38, Fu, Zhonghui wrote: >>> Hi, >>> >>> Any comments are welcome. >> Same comments as here: >> >> http://marc.info/?l=3Dlinux-kernel&m=3D143979428424353&w=3D2 > Now, PM core support asynchronous device suspend/resume mode. If one = device has been set to support asynchronous PM mode, it's suspend/resum= e operation can be performed in a separate kernel thread and take advan= tage of multicore feature to improve overall system suspend/resume spee= d. The worst case is that all device suspend/resume threads will be sch= eduled to the same CPU, it hardly occur. > > PM core ensure all the suspend/resume dependency related to one devic= e. Actually, async suspend/resume mode is one feature of PM core, every= device subsystem may use it or not use it. Once one device subsystem c= hoose to use this feature, its safety is up to PM core as long as devic= e subsystem has initialized fully this device. The original suspend time is 1645ms and resume time is 940ms on ASUS T1= 00TA machine. After enabling "wiphy device", "SDIO device", "mmc host" = and "sdhci-acpi device" to suspend/resume asynchronously, the suspend t= ime is 1096ms and resume time is 908ms. The test environment is listed = as follows: OS: Ubuntu 14.04 Kernel: mainline v4.1 Machine: ASUS T100TA(Baytrail-T platform) Tool: analyze_suspend =E2=80=9Canalyze_suspend.py =E2=80=93f =E2=80=93m freeze=E2=80=9D to su= spend system Press power button to resume system I have resent this patch with updated commit message - "[PATCH v2] mmc/= sdhci-acpi: enable sdhci-acpi device to suspend/resume asynchronously". Thanks, Zhonghui > > > Thanks, > Zhonghui > > >>> Thanks, >>> Zhonghui >>> >>> On 2015/8/3 21:10, Fu, Zhonghui wrote: >>>> Enable sdhci-acpi device to suspend/resume asynchronously. >>>> This can improve system suspend/resume speed. >>>> >>>> Signed-off-by: Zhonghui Fu >>>> --- >>>> drivers/mmc/host/sdhci-acpi.c | 2 ++ >>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhc= i-acpi.c >>>> index 22d929f..67e6263 100644 >>>> --- a/drivers/mmc/host/sdhci-acpi.c >>>> +++ b/drivers/mmc/host/sdhci-acpi.c >>>> @@ -379,6 +379,8 @@ static int sdhci_acpi_probe(struct platform_de= vice *pdev) >>>> pm_runtime_enable(dev); >>>> } >>>> =20 >>>> + device_enable_async_suspend(dev); >>>> + >>>> return 0; >>>> =20 >>>> err_free: >>>> -- 1.7.1 >>>> >>> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kern= el" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/