From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH 0/3] mmc: Wait for card_busy before starting sdio requests Date: Thu, 24 Sep 2015 13:18:00 +0200 Message-ID: <5603DBE8.4000902@broadcom.com> References: <1442935826-16758-1-git-send-email-hdegoede@redhat.com> <5603C020.80603@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:46924 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbbIXLSD (ORCPT ); Thu, 24 Sep 2015 07:18:03 -0400 In-Reply-To: <5603C020.80603@redhat.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Hans de Goede , Ulf Hansson , Doug Anderson Cc: Chris Ball , Maxime Ripard , linux-mmc , "linux-arm-kernel@lists.infradead.org" On 09/24/2015 11:19 AM, Hans de Goede wrote: > Hi, > > On 23-09-15 23:43, Ulf Hansson wrote: >> On 22 September 2015 at 17:30, Hans de Goede wrote: >>> Hi Ulf, >>> >>> Here is a non RFC version of my patch-set to wait for card_busy before >>> starting sdio requests. It is the same as the RFC version of the set, >>> but this time it has been tested no hardware which actually needs this >>> and I can confirm now that this fixes wifi on that hardware. >> >> Great! Thanks, applied for next! > > Great, thanks, I guess it is too late for this to go as a fix into > 4.3-rcX (no worries if it is) ? > >>> This patch-set should also allow removing this dw_mmc specific fix: >>> >>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/host/dw_mmc.c?id=0bdbd0e88cf6b603a2196418672715b0890fb040 >>> >>> >>> As this patch-set fixes this problem in a generic manner. >> >> Care to send a patch to remove the above hack/fix? > > I do not have any hardware to test this. > > I've added Doug the original author of that patch to the Cc. > > Dough, can you test if with the patch set from this mail thread > (merged into mmc/next) this patch: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/mmc/host/dw_mmc.c?id=0bdbd0e88cf6b603a2196418672715b0890fb040 > > > Is still necessary ? Since this patch-set fixes the same issue > in the mmc core I believe that this commit can be reverted now. I have a chromebook which has this hack/patch (more or less) in chromeos. I can try and backport your patches and see how it goes. Regards, Arend > Thanks & Regards, > > Hans