From: Alim Akhtar <alim.akhtar@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>, linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org, k.kozlowski@samsung.com,
linux.amoon@gmail.com, jh80.chung@gmail.com
Subject: Re: [2/2] mmc: dw_mmc: fix the wrong setting for UHS-DDR50 mode
Date: Wed, 21 Oct 2015 16:51:42 +0530 [thread overview]
Message-ID: <56277546.8020105@samsung.com> (raw)
In-Reply-To: <1445424582-7940-2-git-send-email-jh80.chung@samsung.com>
Hi Jaehoon,
On 10/21/2015 04:19 PM, Jaehoon Chung wrote:
> When card is running with DDR mode, dwmmc needs to set DDR_REG bit at
> UHS_REG register.
> Before this patch, dwmmc controller doesn't consider this.
> If this patch is not applied, CRC or other error shoulds be occurred.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
Looks good to me,
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested on peach board with some additional dt changes, works well.
so, Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 6e600e8..cb31e8e 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -1295,6 +1295,7 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>
> /* DDR mode set */
> if (ios->timing == MMC_TIMING_MMC_DDR52 ||
> + ios->timing == MMC_TIMING_UHS_DDR50 ||
> ios->timing == MMC_TIMING_MMC_HS400)
> regs |= ((0x1 << slot->id) << 16);
> else
>
next prev parent reply other threads:[~2015-10-21 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 10:49 [PATCH 1/2] mmc: dw_mmc: fix the CardThreshold boundary at CardThrCtl register Jaehoon Chung
2015-10-21 10:49 ` [PATCH 2/2] mmc: dw_mmc: fix the wrong setting for UHS-DDR50 mode Jaehoon Chung
2015-10-21 11:21 ` Alim Akhtar [this message]
2015-10-21 11:25 ` [1/2] mmc: dw_mmc: fix the CardThreshold boundary at CardThrCtl register Alim Akhtar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56277546.8020105@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=jh80.chung@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).