From: Scott Branden <sbranden@broadcom.com>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Ray Jui <rjui@broadcom.com>, Jon Mason <jonmason@broadcom.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
kernel@martin.sperl.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/5 RFC] mmc: sdhci-iproc: Clean up platform allocations if shdci init fails
Date: Mon, 18 Jan 2016 13:31:04 -0800 [thread overview]
Message-ID: <569D5998.80204@broadcom.com> (raw)
In-Reply-To: <1453042744-16196-2-git-send-email-stefan.wahren@i2se.com>
This patch looks fine.
On 16-01-17 06:59 AM, Stefan Wahren wrote:
> This patch adopts the changes from 475c9e43bfa7 ("mmc: sdhci-bcm2835:
> Clean up platform allocations if sdhci init fails") to sdhci-iproc.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Scott Branden <sbranden@broadcom.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..e22060a 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -213,7 +213,11 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
> host->caps1 = iproc_host->data->caps1;
> }
>
> - return sdhci_add_host(host);
> + ret = sdhci_add_host(host);
> + if (ret)
> + goto err;
> +
> + return 0;
>
> err:
> sdhci_pltfm_free(pdev);
>
next prev parent reply other threads:[~2016-01-18 21:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 14:58 [PATCH 0/5 RFC] mmc: sdhci-iproc: add bcm2835 support Stefan Wahren
[not found] ` <1453042744-16196-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-01-17 14:59 ` [PATCH 1/5 RFC] mmc: sdhci-iproc: Clean up platform allocations if shdci init fails Stefan Wahren
2016-01-18 21:31 ` Scott Branden [this message]
2016-01-27 14:16 ` Ulf Hansson
2016-01-17 14:59 ` [PATCH 2/5 RFC] mmc: sdhci-iproc: Actually enable the clock Stefan Wahren
2016-01-18 21:35 ` Scott Branden
[not found] ` <1453042744-16196-3-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-01-27 14:16 ` Ulf Hansson
2016-01-27 19:11 ` Stefan Wahren
2016-01-27 21:11 ` Ulf Hansson
2016-01-17 14:59 ` [PATCH 3/5 RFC] ARM: bcm283x: specify sdhci quirks in dtsi file Stefan Wahren
2016-01-18 21:40 ` Scott Branden
[not found] ` <1453042744-16196-4-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-01-26 4:31 ` Stephen Warren
2016-01-17 14:59 ` [PATCH 4/5 RFC] mmc: sdhci-iproc: add bcm2835 support Stefan Wahren
2016-01-18 21:47 ` Scott Branden
2016-01-19 19:25 ` Stefan Wahren
2016-01-19 19:47 ` Scott Branden
2016-01-19 1:32 ` Jaehoon Chung
[not found] ` <569D923D.60306-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-01-20 21:23 ` Stefan Wahren
[not found] ` <1453042744-16196-5-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-01-26 4:34 ` Stephen Warren
2016-01-17 14:59 ` [PATCH 5/5 RFC] DT: sdhci-iproc: add bcm2835 compatible Stefan Wahren
2016-01-18 21:47 ` Scott Branden
2016-01-20 16:50 ` Rob Herring
2016-01-19 21:00 ` [PATCH 0/5 RFC] mmc: sdhci-iproc: add bcm2835 support Eric Anholt
2016-01-20 21:18 ` Stefan Wahren
2016-01-28 22:19 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569D5998.80204@broadcom.com \
--to=sbranden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=jonmason@broadcom.com \
--cc=kernel@martin.sperl.org \
--cc=lee@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=swarren@wwwdotorg.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).