From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Fu, Zhonghui" Subject: Re: [PATCH 1/2] mmc: enable mmc host device to suspend/resume asynchronously Date: Fri, 22 Jan 2016 11:37:08 +0800 Message-ID: <56A1A3E4.20905@linux.intel.com> References: <568157A7.8030607@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com ([192.55.52.93]:7203 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbcAVDhS (ORCPT ); Thu, 21 Jan 2016 22:37:18 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ulf Hansson Cc: Adrian Hunter , Chaotian Jing , Lars-Peter Clausen , Venu Byravarasu , Sergei Shtylyov , linux-mmc , "linux-kernel@vger.kernel.org" On 1/12/2016 10:42 PM, Ulf Hansson wrote: > On 28 December 2015 at 16:39, Fu, Zhonghui wrote: >> Now, PM core supports asynchronous suspend/resume mode for devices >> during system suspend/resume, and the power state transition of one >> device may be completed in separate kernel thread. PM core ensures >> all power state transition dependency between devices. This patch >> enables mmc hosts to suspend/resume asynchronously. This will take >> advantage of multicore and improve system suspend/resume speed. >> After applying this patch and enabling all mmc hosts' child devices >> to suspend/resume asynchronously on ASUS T100TA, the system >> suspend-to-idle time is reduced from 1645ms to 1107ms, and the >> system resume time is reduced from 940ms to 914ms. > Please update the change log as I don't think the above is really correct. > > I think you can simplify the change log quite a bit and just mention > what and why we want this change. I have updated the change log according to your comments and resent this patch - "[PATCH 1/2 v2] mmc: enable mmc host device to suspend/resume asynchronously". Thanks, Zhonghui > >> Signed-off-by: Zhonghui Fu >> --- >> drivers/mmc/core/host.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c >> index da950c4..7222fd7 100644 >> --- a/drivers/mmc/core/host.c >> +++ b/drivers/mmc/core/host.c >> @@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev) >> host->class_dev.parent = dev; >> host->class_dev.class = &mmc_host_class; >> device_initialize(&host->class_dev); >> + device_enable_async_suspend(&host->class_dev); >> >> if (mmc_gpio_alloc(host)) { >> put_device(&host->class_dev); >> -- 1.7.1 >> > Otherwise I think this looks good! > > Kind regards > Uffe