From: Scott Branden <sbranden@broadcom.com>
To: Jisheng Zhang <jszhang@marvell.com>,
ulf.hansson@linaro.org, rjui@broadcom.com, jonmason@broadcom.com
Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly
Date: Tue, 26 Jan 2016 18:00:31 -0800 [thread overview]
Message-ID: <56A824BF.3030202@broadcom.com> (raw)
In-Reply-To: <1453803963-6385-1-git-send-email-jszhang@marvell.com>
Hi Jisheng,
Looks good.
Acked-by: Scott Branden <sbranden@broadcom.com>
On 16-01-26 02:26 AM, Jisheng Zhang wrote:
> The sdhci_iproc_remove() is jsut a wrapper to sdhci_pltfm_unregister.
> So use the sdhci_pltfm_unregister() for the .remove hook directly.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/mmc/host/sdhci-iproc.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 3b423b0..24c5546 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -220,11 +220,6 @@ err:
> return ret;
> }
>
> -static int sdhci_iproc_remove(struct platform_device *pdev)
> -{
> - return sdhci_pltfm_unregister(pdev);
> -}
> -
> static struct platform_driver sdhci_iproc_driver = {
> .driver = {
> .name = "sdhci-iproc",
> @@ -232,7 +227,7 @@ static struct platform_driver sdhci_iproc_driver = {
> .pm = SDHCI_PLTFM_PMOPS,
> },
> .probe = sdhci_iproc_probe,
> - .remove = sdhci_iproc_remove,
> + .remove = sdhci_pltfm_unregister,
> };
> module_platform_driver(sdhci_iproc_driver);
>
>
next prev parent reply other threads:[~2016-01-27 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 10:26 [PATCH] mmc: sdhci-iproc: use sdhci_pltfm_unregister directly Jisheng Zhang
2016-01-27 2:00 ` Scott Branden [this message]
2016-02-02 13:11 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A824BF.3030202@broadcom.com \
--to=sbranden@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jonmason@broadcom.com \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).