linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Shawn Lin <shawn.lin@rock-chips.com>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops
Date: Thu, 04 Feb 2016 15:15:03 +0900	[thread overview]
Message-ID: <56B2EC67.4010909@samsung.com> (raw)
In-Reply-To: <1454470004-21408-1-git-send-email-shawn.lin@rock-chips.com>

Hi, Shawn.

On 02/03/2016 12:26 PM, Shawn Lin wrote:
> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
> have done. Let's remove it.

Yep, it's possible to remove.
I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume.
Could you check this?

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index d9c92f3..3438ab3 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
>  	return dw_mci_pltfm_register(pdev, drv_data);
>  }
>  
> -#ifdef CONFIG_PM_SLEEP
> -static int dw_mci_rockchip_suspend(struct device *dev)
> -{
> -	struct dw_mci *host = dev_get_drvdata(dev);
> -
> -	return dw_mci_suspend(host);
> -}
> -
> -static int dw_mci_rockchip_resume(struct device *dev)
> -{
> -	struct dw_mci *host = dev_get_drvdata(dev);
> -
> -	return dw_mci_resume(host);
> -}
> -#endif /* CONFIG_PM_SLEEP */
> -
> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
> -			 dw_mci_rockchip_suspend,
> -			 dw_mci_rockchip_resume);
> -
>  static struct platform_driver dw_mci_rockchip_pltfm_driver = {
>  	.probe		= dw_mci_rockchip_probe,
>  	.remove		= dw_mci_pltfm_remove,
>  	.driver		= {
>  		.name		= "dwmmc_rockchip",
>  		.of_match_table	= dw_mci_rockchip_match,
> -		.pm		= &dw_mci_rockchip_pmops,
> +		.pm		= &dw_mci_pltfm_pmops,
>  	},
>  };
>  
> 


  reply	other threads:[~2016-02-04  6:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03  3:26 [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops Shawn Lin
2016-02-04  6:15 ` Jaehoon Chung [this message]
2016-02-12 11:42   ` Shawn Lin
2016-03-29  1:17     ` Jaehoon Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B2EC67.4010909@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).