* [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops
@ 2016-02-03 3:26 Shawn Lin
2016-02-04 6:15 ` Jaehoon Chung
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Lin @ 2016-02-03 3:26 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Shawn Lin
dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
have done. Let's remove it.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index d9c92f3..3438ab3 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
return dw_mci_pltfm_register(pdev, drv_data);
}
-#ifdef CONFIG_PM_SLEEP
-static int dw_mci_rockchip_suspend(struct device *dev)
-{
- struct dw_mci *host = dev_get_drvdata(dev);
-
- return dw_mci_suspend(host);
-}
-
-static int dw_mci_rockchip_resume(struct device *dev)
-{
- struct dw_mci *host = dev_get_drvdata(dev);
-
- return dw_mci_resume(host);
-}
-#endif /* CONFIG_PM_SLEEP */
-
-static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
- dw_mci_rockchip_suspend,
- dw_mci_rockchip_resume);
-
static struct platform_driver dw_mci_rockchip_pltfm_driver = {
.probe = dw_mci_rockchip_probe,
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_rockchip",
.of_match_table = dw_mci_rockchip_match,
- .pm = &dw_mci_rockchip_pmops,
+ .pm = &dw_mci_pltfm_pmops,
},
};
--
2.3.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops
2016-02-03 3:26 [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops Shawn Lin
@ 2016-02-04 6:15 ` Jaehoon Chung
2016-02-12 11:42 ` Shawn Lin
0 siblings, 1 reply; 4+ messages in thread
From: Jaehoon Chung @ 2016-02-04 6:15 UTC (permalink / raw)
To: Shawn Lin, Ulf Hansson; +Cc: linux-mmc, linux-kernel
Hi, Shawn.
On 02/03/2016 12:26 PM, Shawn Lin wrote:
> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
> have done. Let's remove it.
Yep, it's possible to remove.
I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume.
Could you check this?
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index d9c92f3..3438ab3 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
> return dw_mci_pltfm_register(pdev, drv_data);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int dw_mci_rockchip_suspend(struct device *dev)
> -{
> - struct dw_mci *host = dev_get_drvdata(dev);
> -
> - return dw_mci_suspend(host);
> -}
> -
> -static int dw_mci_rockchip_resume(struct device *dev)
> -{
> - struct dw_mci *host = dev_get_drvdata(dev);
> -
> - return dw_mci_resume(host);
> -}
> -#endif /* CONFIG_PM_SLEEP */
> -
> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
> - dw_mci_rockchip_suspend,
> - dw_mci_rockchip_resume);
> -
> static struct platform_driver dw_mci_rockchip_pltfm_driver = {
> .probe = dw_mci_rockchip_probe,
> .remove = dw_mci_pltfm_remove,
> .driver = {
> .name = "dwmmc_rockchip",
> .of_match_table = dw_mci_rockchip_match,
> - .pm = &dw_mci_rockchip_pmops,
> + .pm = &dw_mci_pltfm_pmops,
> },
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops
2016-02-04 6:15 ` Jaehoon Chung
@ 2016-02-12 11:42 ` Shawn Lin
2016-03-29 1:17 ` Jaehoon Chung
0 siblings, 1 reply; 4+ messages in thread
From: Shawn Lin @ 2016-02-12 11:42 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson; +Cc: shawn.lin, linux-mmc, linux-kernel
On 2016/2/4 14:15, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
>> have done. Let's remove it.
>
> Yep, it's possible to remove.
> I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume.
> Could you check this?
Jaehoon,
:) I can't say "never plan to add anything" in case of some broken Socs
need something special to do in the future. But I will that would not
happen, and personally we not going to add specific code here.
Thanks for sharing your thought.
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>> drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
>> 1 file changed, 1 insertion(+), 21 deletions(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
>> index d9c92f3..3438ab3 100644
>> --- a/drivers/mmc/host/dw_mmc-rockchip.c
>> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
>> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
>> return dw_mci_pltfm_register(pdev, drv_data);
>> }
>>
>> -#ifdef CONFIG_PM_SLEEP
>> -static int dw_mci_rockchip_suspend(struct device *dev)
>> -{
>> - struct dw_mci *host = dev_get_drvdata(dev);
>> -
>> - return dw_mci_suspend(host);
>> -}
>> -
>> -static int dw_mci_rockchip_resume(struct device *dev)
>> -{
>> - struct dw_mci *host = dev_get_drvdata(dev);
>> -
>> - return dw_mci_resume(host);
>> -}
>> -#endif /* CONFIG_PM_SLEEP */
>> -
>> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
>> - dw_mci_rockchip_suspend,
>> - dw_mci_rockchip_resume);
>> -
>> static struct platform_driver dw_mci_rockchip_pltfm_driver = {
>> .probe = dw_mci_rockchip_probe,
>> .remove = dw_mci_pltfm_remove,
>> .driver = {
>> .name = "dwmmc_rockchip",
>> .of_match_table = dw_mci_rockchip_match,
>> - .pm = &dw_mci_rockchip_pmops,
>> + .pm = &dw_mci_pltfm_pmops,
>> },
>> };
>>
>>
>
>
>
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops
2016-02-12 11:42 ` Shawn Lin
@ 2016-03-29 1:17 ` Jaehoon Chung
0 siblings, 0 replies; 4+ messages in thread
From: Jaehoon Chung @ 2016-03-29 1:17 UTC (permalink / raw)
To: Shawn Lin, Ulf Hansson; +Cc: linux-mmc, linux-kernel
Hi Shawn,
Sorry for applying late.
Applied on my repository.
Best Regards,
Jaehoon Chung
On 02/12/2016 08:42 PM, Shawn Lin wrote:
> On 2016/2/4 14:15, Jaehoon Chung wrote:
>> Hi, Shawn.
>>
>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
>>> have done. Let's remove it.
>>
>> Yep, it's possible to remove.
>> I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume.
>> Could you check this?
>
> Jaehoon,
>
> :) I can't say "never plan to add anything" in case of some broken Socs
> need something special to do in the future. But I will that would not happen, and personally we not going to add specific code here.
>
> Thanks for sharing your thought.
>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>> ---
>>>
>>> drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
>>> 1 file changed, 1 insertion(+), 21 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
>>> index d9c92f3..3438ab3 100644
>>> --- a/drivers/mmc/host/dw_mmc-rockchip.c
>>> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
>>> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
>>> return dw_mci_pltfm_register(pdev, drv_data);
>>> }
>>>
>>> -#ifdef CONFIG_PM_SLEEP
>>> -static int dw_mci_rockchip_suspend(struct device *dev)
>>> -{
>>> - struct dw_mci *host = dev_get_drvdata(dev);
>>> -
>>> - return dw_mci_suspend(host);
>>> -}
>>> -
>>> -static int dw_mci_rockchip_resume(struct device *dev)
>>> -{
>>> - struct dw_mci *host = dev_get_drvdata(dev);
>>> -
>>> - return dw_mci_resume(host);
>>> -}
>>> -#endif /* CONFIG_PM_SLEEP */
>>> -
>>> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
>>> - dw_mci_rockchip_suspend,
>>> - dw_mci_rockchip_resume);
>>> -
>>> static struct platform_driver dw_mci_rockchip_pltfm_driver = {
>>> .probe = dw_mci_rockchip_probe,
>>> .remove = dw_mci_pltfm_remove,
>>> .driver = {
>>> .name = "dwmmc_rockchip",
>>> .of_match_table = dw_mci_rockchip_match,
>>> - .pm = &dw_mci_rockchip_pmops,
>>> + .pm = &dw_mci_pltfm_pmops,
>>> },
>>> };
>>>
>>>
>>
>>
>>
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-29 1:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-03 3:26 [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops Shawn Lin
2016-02-04 6:15 ` Jaehoon Chung
2016-02-12 11:42 ` Shawn Lin
2016-03-29 1:17 ` Jaehoon Chung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).