From: Shawn Lin <shawn.lin@rock-chips.com>
To: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: shawn.lin@rock-chips.com, shawn.lin@kernel-upstream.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR
Date: Mon, 15 Feb 2016 08:20:14 +0800 [thread overview]
Message-ID: <56C119BE.8000608@rock-chips.com> (raw)
In-Reply-To: <56C0FFD7.60406@samsung.com>
Hi Jaehoon,
On 2016/2/15 6:29, Jaehoon Chung wrote:
> On 02/15/2016 07:27 AM, Jaehoon Chung wrote:
>> On 02/12/2016 08:31 PM, Shawn Lin wrote:
>>> On 2016/2/4 14:12, Jaehoon Chung wrote:
>>>> Hi, Shawn.
>>>>
>>>> On 02/03/2016 12:26 PM, Shawn Lin wrote:
>>>>> EVENT_XFER_ERROR isn't been used now, so we can
>>>>> remove it.
>>>>
>>>> If you are ok, after changing the commit message, I will apply this.
>>>> Thanks!
>>>
>>> Should I respin v2 to amend the commit msg? :-)
>>
>> Not important..but i want to use this. :)
>> "we can remove it" -> "It can be removed."
>
yes, please.
> One more..This patch is [1/2]..I didn't see the second patch [2/2].
Only one patch here, no [2/2]. sorry for the noise
>
>>
>> Best Regards,
>> Jaehoon Chung
>>
>>>
>>>>
>>>> Best Regards,
>>>> Jaehoon Chung
>>>>
>>>>>
>>>>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>>>>> ---
>>>>>
>>>>> include/linux/mmc/dw_mmc.h | 1 -
>>>>> 1 file changed, 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
>>>>> index 89df7ab..b29e06e 100644
>>>>> --- a/include/linux/mmc/dw_mmc.h
>>>>> +++ b/include/linux/mmc/dw_mmc.h
>>>>> @@ -36,7 +36,6 @@ enum {
>>>>> EVENT_XFER_COMPLETE,
>>>>> EVENT_DATA_COMPLETE,
>>>>> EVENT_DATA_ERROR,
>>>>> - EVENT_XFER_ERROR
>>>>> };
>>>>>
>>>>> struct mmc_data;
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>
>
>
>
--
Best Regards
Shawn Lin
prev parent reply other threads:[~2016-02-15 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 3:26 [PATCH 1/2] mmc: dw_mmc: remove unused EVENT_XFER_ERROR Shawn Lin
2016-02-04 6:12 ` Jaehoon Chung
2016-02-12 11:31 ` Shawn Lin
2016-02-14 22:27 ` Jaehoon Chung
2016-02-14 22:29 ` Jaehoon Chung
2016-02-15 0:20 ` Shawn Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C119BE.8000608@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@kernel-upstream.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).