From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 1/2] mmc: tegra: properly disable card clock Date: Thu, 17 Mar 2016 11:29:47 +0000 Message-ID: <56EA952B.5020900@nvidia.com> References: <1456779385-18996-1-git-send-email-dev@lynxeye.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate16.nvidia.com ([216.228.121.65]:1168 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932876AbcCQL36 (ORCPT ); Thu, 17 Mar 2016 07:29:58 -0400 In-Reply-To: <1456779385-18996-1-git-send-email-dev@lynxeye.de> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Lucas Stach , Ulf Hansson , Adrian Hunter Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org On 29/02/16 20:56, Lucas Stach wrote: > The new code to do the clock rate setting externally to the SDMMC > module has a shortcut to not propagate changes with a 0 rate to > the CAR by simply bailing out. This breaks proper cutting of the > card clock. Fix it by directly calling the correct sdhci function. > > Fixes: a8e326a911d3 "mmc: tegra: implement module external clock change" > Signed-off-by: Lucas Stach > --- > drivers/mmc/host/sdhci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c > index 212d51f..46a6bd1 100644 > --- a/drivers/mmc/host/sdhci-tegra.c > +++ b/drivers/mmc/host/sdhci-tegra.c > @@ -194,7 +194,7 @@ static void tegra_sdhci_set_clock(struct sdhci_host *host, unsigned int clock) > unsigned long host_clk; > > if (!clock) > - return; > + return sdhci_set_clock(host, clock);; Looks like the above adds an unnecessary additional semi-colon. Ulf, are you able to correct, or do you want a patch? Cheers Jon