From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Subject: Re: [PATCH v2 0/3] Cleanup setup_clock callback from dw_mmc Date: Fri, 01 Apr 2016 09:27:32 +0900 Message-ID: <56FDC074.2010501@samsung.com> References: <1459409616-20306-1-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:37007 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752422AbcDAA1f (ORCPT ); Thu, 31 Mar 2016 20:27:35 -0400 In-reply-to: <1459409616-20306-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org Hi, On 03/31/2016 04:33 PM, Shawn Lin wrote: > Hello Jeahoon > > Currently dw_mmc is a little too queen-size. As we had cleanup > prepare_command callback some days before, there are also some > ones deserve to remove. Also we should avoid add new quirks or > callbacks into dw_mmc in order to avoid the dilemma sdhci meets > now. > > This patchset remove setup_clock callback. Obviously, add a callback > just for one-time-used clk stuff make no sense. We combine what > setup_clock does before into init callback. For exynos platfrom, it > needs call init hook after resume, so we add new argument in init hook > to indicate whether it needs do clk stuff or not. Thanks for resending these. This message looks like previous message.. Anyway, i will pick you patch with my patch.. Best Regards, Jaehoon Chung > > > Changes in v2: > - rebase on linux-mmc next > - remove add setup_clk flag for init callback > > Shawn Lin (3): > mmc: dw_mmc-rockchip: remove setup_clock for rockchip > mmc: dw_mmc-exynos: remove dw_mci_exynos_setup_clock > mmc: dw_mmc: remove setup_clock callback > > drivers/mmc/host/dw_mmc-exynos.c | 8 -------- > drivers/mmc/host/dw_mmc-rockchip.c | 12 ++++-------- > drivers/mmc/host/dw_mmc.c | 9 --------- > drivers/mmc/host/dw_mmc.h | 2 -- > 4 files changed, 4 insertions(+), 27 deletions(-) >