From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Tomas Winkler <tomas.winkler@intel.com>,
gregkh@linuxfoundation.org, Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Yaniv Gardi <ygardi@codeaurora.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: [PATCH 8/8] scsi: ufs: connect to RPMB subsystem
Date: Mon, 4 Apr 2016 11:32:01 +0100 [thread overview]
Message-ID: <570242A1.6020501@synopsys.com> (raw)
In-Reply-To: <1459676572-29921-9-git-send-email-tomas.winkler@intel.com>
Hi!
On 4/3/2016 10:42 AM, Tomas Winkler wrote:
> Register UFS RPMB LUN with the RPMB subsystem and provide
> implementation for the RPMB access operations. RPMB partition is
> accessed via a sequence of security protocol in and security protocol
> out commands with UFS specific parameters. This multi step process is
> abstracted into 4 basic RPMB commands.
>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 219 ++++++++++++++++++++++++++++++++++++++++++++++
> drivers/scsi/ufs/ufshcd.h | 2 +
> 2 files changed, 221 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f8fa72c31a9d..c087e9713db3 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -37,10 +37,13 @@
> * license terms, and distributes only under these terms.
> */
>
[snip]
> scsi_remove_host(hba->host);
> /* disable interrupts */
> ufshcd_disable_intr(hba, hba->intr_mask);
> diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
> index 4bb65669f052..92bfddf80ae8 100644
> --- a/drivers/scsi/ufs/ufshcd.h
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -346,6 +346,7 @@ struct ufs_init_prefetch {
> * @utmrdl_dma_addr: UTMRDL DMA address
> * @host: Scsi_Host instance of the driver
> * @dev: device handle
> + * @sdev_ufs_rpmb: reference to RPMB device W-LU
> * @lrb: local reference block
> * @lrb_in_use: lrb in use
> * @outstanding_tasks: Bits representing outstanding task requests
> @@ -408,6 +409,7 @@ struct ufs_hba {
> * "UFS device" W-LU.
> */
> struct scsi_device *sdev_ufs_device;
> + struct scsi_device *sdev_ufs_rpmb;
>
> enum ufs_dev_pwr_mode curr_dev_pwr_mode;
> enum uic_link_state uic_link_state;
>
I saw some kbuild robot issues regarding the patchset, so I would suggest you
make a v2 of the patch set and I can run some tests with the DW UFS Host design.
Thanks.
Joao
next prev parent reply other threads:[~2016-04-04 10:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-03 9:42 [PATCH 0/8] Replay Protected Memory Block (RPMB) subsystem Tomas Winkler
2016-04-03 9:42 ` [PATCH 1/8] rpmb: add " Tomas Winkler
2016-04-03 9:42 ` [PATCH 2/8] char: rpmb: add sysfs-class ABI documentation Tomas Winkler
2016-04-24 9:19 ` Pavel Machek
2016-04-24 16:27 ` Winkler, Tomas
2016-04-03 9:42 ` [PATCH 3/8] char: rpmb: add device attributes Tomas Winkler
2016-04-03 9:42 ` [PATCH 4/8] char: rpmb: provide user space interface Tomas Winkler
2016-04-03 10:36 ` [PATCH] char: rpmb: fix memdup_user.cocci warnings kbuild test robot
2016-04-03 10:36 ` [PATCH 4/8] char: rpmb: provide user space interface kbuild test robot
2016-04-03 9:42 ` [PATCH 5/8] char: rpmb: add RPMB simulation device Tomas Winkler
2016-04-03 10:45 ` kbuild test robot
2016-04-03 10:45 ` [PATCH] char: rpmb: fix platform_no_drv_owner.cocci warnings kbuild test robot
2016-04-03 15:35 ` [PATCH 5/8] char: rpmb: add RPMB simulation device kbuild test robot
2016-04-03 9:42 ` [PATCH 6/8] tools rpmb: add RPBM access tool Tomas Winkler
2016-04-04 0:55 ` kbuild test robot
2016-04-03 9:42 ` [PATCH 7/8] mmc: block: register rpmb partition with the RPMB subsystem Tomas Winkler
2016-04-03 9:42 ` [PATCH 8/8] scsi: ufs: connect to " Tomas Winkler
2016-04-04 10:32 ` Joao Pinto [this message]
2016-04-04 10:35 ` Winkler, Tomas
2016-04-03 13:27 ` [PATCH 0/8] Replay Protected Memory Block (RPMB) subsystem Andy Lutomirski
2016-04-03 19:27 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570242A1.6020501@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=adrian.hunter@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tomas.winkler@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).