From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH v3 0/5] davinci_mmc fixes Date: Tue, 5 Apr 2016 12:11:23 -0500 Message-ID: <5703F1BB.1090401@lechnology.com> References: <1458186341-6970-1-git-send-email-david@lechnology.com> <5703ECFE.6060706@lechnology.com> <5703F0DF.3020209@lechnology.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <5703F0DF.3020209@lechnology.com> Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: Sekhar Nori , Kevin Hilman , Russell King , Jaehoon Chung , Krzysztof Kozlowski , Peter Ujfalusi , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-mmc List-Id: linux-mmc@vger.kernel.org On 04/05/2016 12:07 PM, David Lechner wrote: > On 04/05/2016 11:51 AM, David Lechner wrote: >> On 04/05/2016 06:12 AM, Ulf Hansson wrote: >>> >>> Patch 3 triggers a compiler warning, please fix it. >>> >>> ../drivers/mmc/host/davinci_mmc.c: In function =E2=80=98davinci_mmc= sd_probe=E2=80=99: >>> ../drivers/mmc/host/davinci_mmc.c:1208:6: warning: =E2=80=98ret=E2=80= =99 may be used >>> uninitialized in this function [-Wmaybe-uninitialized] >>> >>> I have applied patch 1->2 for next, so no need to resend these. >>> >>> Kind regards >>> Uffe >>> >> >> I am not getting a compiler warning with this commit. Can you please >> provide a git link so that I can be sure I am building using the sam= e >> branch that you are using? > > > I think I figured it out. I am applying the patches on top of the nex= t > branch from git://git.linaro.org/people/ulf.hansson/mmc.git. However,= I > am still not getting a compiler warning. Perhaps it has to do with th= e > gcc version. I'm not exactly sure how to fix it since it is really no= t > used uninitialized. Just set it to 0 in the variable declaration? OK. I guess it is my compiler that is broken. :-/ I stared at it long enough and I see the error now.