From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 4/5] mmc: sdhci: Fix error paths in sdhci_add_host()
Date: Wed, 13 Apr 2016 14:41:29 +0300 [thread overview]
Message-ID: <570E3069.5010903@intel.com> (raw)
In-Reply-To: <CAPDyKFqJf4hNVeYw8wvp3aOp9fLSXMADVrGaBeZFG=QLAR1tZg@mail.gmail.com>
On 13/04/16 14:41, Ulf Hansson wrote:
> [...]
>
>>
>> pr_info("%s: SDHCI controller on %s [%s] using %s\n",
>> mmc_hostname(mmc), host->hw_name, dev_name(mmc_dev(mmc)),
>> @@ -3331,15 +3337,27 @@ int sdhci_add_host(struct sdhci_host *host)
>>
>> return 0;
>>
>> +unled:
>> #ifdef SDHCI_USE_LEDS_CLASS
>
> Shouldn't this ifdef be removed in the earlier patch?
It gets removed in the next patch. Is that what you meant?
>
>> -reset:
>> + led_classdev_unregister(&host->led);
>> +unirq:
>> +#endif
>> sdhci_do_reset(host, SDHCI_RESET_ALL);
>> sdhci_writel(host, 0, SDHCI_INT_ENABLE);
>> sdhci_writel(host, 0, SDHCI_SIGNAL_ENABLE);
>> free_irq(host->irq, host);
>> -#endif
>> untasklet:
>> tasklet_kill(&host->finish_tasklet);
>> +unreg:
>> + if (!IS_ERR(mmc->supply.vqmmc))
>> + regulator_disable(mmc->supply.vqmmc);
>> +undma:
>> + if (host->align_buffer)
>> + dma_free_coherent(mmc_dev(mmc), host->align_buffer_sz +
>> + host->adma_table_sz, host->align_buffer,
>> + host->align_addr);
>> + host->adma_table = NULL;
>> + host->align_buffer = NULL;
>>
>> return ret;
>> }
>> --
>> 1.9.1
>>
>
> Kind regards
> Uffe
>
next prev parent reply other threads:[~2016-04-13 11:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 11:25 [PATCH 0/5] mmc: sdhci: Misc patches Adrian Hunter
2016-04-12 11:25 ` [PATCH 1/5] mmc: sdhci-pci: Set MMC_CAP_AGGRESSIVE_PM for Broxton controllers Adrian Hunter
2016-04-12 11:25 ` [PATCH 2/5] mmc: sdhci-acpi: " Adrian Hunter
2016-04-12 11:25 ` [PATCH 3/5] mmc: sdhci: Remove redundant condition Adrian Hunter
2016-04-12 11:25 ` [PATCH 4/5] mmc: sdhci: Fix error paths in sdhci_add_host() Adrian Hunter
2016-04-13 11:41 ` Ulf Hansson
2016-04-13 11:41 ` Adrian Hunter [this message]
2016-04-13 11:47 ` Ulf Hansson
2016-04-12 11:25 ` [PATCH 5/5] mmc: sdhci: Tidy together LED code Adrian Hunter
2016-04-13 11:42 ` Ulf Hansson
2016-04-13 11:45 ` Adrian Hunter
2016-04-13 12:15 ` Ulf Hansson
2016-04-13 12:36 ` Adrian Hunter
2016-04-13 13:45 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E3069.5010903@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox