[PATCH v2 2/7] mmc: sdhci-pltfm: check return value of platform_get_irq()

Masahiro Yamada
2016-04-20T02:15:56Z

The function platform_get_irq() can fail; it returns a negative error
code on failure. A negative IRQ number will make sdhci_add_host() fail
to request IRQ anyway, but it makes sense to let it fail earlier here.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

Changes in v2:
- Add \n to the tail of the error message

drivers/mmc/host/sdhci-pltfm.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 03dbdeb..24377a3 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -146,6 +146,11 @@ struct sdhci_host *sdhci_pltfm_init(struct platform_device *pdev,
}

host->irq = platform_get_irq(pdev, 0);
+ if (host->irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ number\n");
+ ret = host->irq;
+ goto err_request;
+ }

if (!request_mem_region(iomem->start, resource_size(iomem),
mmc_hostname(host->mmc))) {
--
1.9.1