Re: [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set

Andrew F. Davis
2016-06-17T22:46:21Z

On 06/15/2016 01:48 AM, Jacek Anaszewski wrote:
> Hi Andrew,
>
> Thanks for the patch.
>
> Please address the issue [1] raised by test bot and resubmit.
>
> Thanks,
> Jacek Anaszewski
>
> [1] https://lkml.org/lkml/2016/6/13/1091
>

It looks like some systems use 'gpio_led_register_device' to make an
in-memory copy of their LED device table so the original can be removed
as .init.rodata. This doesn't necessarily depend on the LED subsystem
but it kind of seems useless when the rest of the subsystem is disabled.

One solution could be to use a dummy 'gpio_led_register_device' when the
subsystem is not enabled. Another is just to remove the five or so uses
of 'gpio_led_register_device' and have those systems register LED device
tables like other systems do.

If nether of these are acceptable then this patch can be dropped from
this series for now.

Thanks,
Andrew

> On 06/13/2016 10:02 PM, Andrew F. Davis wrote:
>> When CONFIG_NEW_LEDS is not set make will still descend into the leds
>> directory but nothing will be built. This produces unneeded build
>> artifacts and messages in addition to slowing the build. Fix this here.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>> drivers/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/Makefile b/drivers/Makefile
>> index 567e32c..fa514d5 100644
>> --- a/drivers/Makefile
>> +++ b/drivers/Makefile
>> @@ -127,7 +127,7 @@ obj-$(CONFIG_CPU_FREQ) += cpufreq/
>> obj-$(CONFIG_CPU_IDLE) += cpuidle/
>> obj-$(CONFIG_MMC) += mmc/
>> obj-$(CONFIG_MEMSTICK) += memstick/
>> -obj-y += leds/
>> +obj-$(CONFIG_NEW_LEDS) += leds/
>> obj-$(CONFIG_INFINIBAND) += infiniband/
>> obj-$(CONFIG_SGI_SN) += sn/
>> obj-y += firmware/
>>
>
>