Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

Sebastian Reichel
2016-06-15T12:48:42Z

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

Hi Andrew,

On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote:
> If the HSI core is built as a module hsi_boardinfo may still
> be built-in as its Kconfig type is bool, which can cause build
> issues. Fix this by building this code into the HSI core when
> enabled.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> This build error seems to be due to Kconfig symbol CONFIG_HSI_BOARDINFO
> being a bool but depending on a tristate (CONFIG_HSI). This is normally
> okay when it is just a flag to enable a feature in source, but the
> helper code file hsi_boardinfo.c is built as a separate entity when
> enabled. This patch is probably how it was intended, and is more like
> how others do this kind of thing.
>
> This patch should be applied before the parent patch:

Thanks, I applied both patches.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]