From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
Linus Walleij <linus.walleij@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
linux-i2c@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
lguest@lists.ozlabs.org, Samuel Ortiz <sameo@linux.intel.com>,
Russell King <linux@armlinux.org.uk>,
linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org,
linux-media@vger.kernel.org, linux-pwm@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-gpio@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Lauro Ramos Venancio <lauro.venancio@openbossa.org>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Richard Purdie <rpurdie@rpsys.net>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS is set
Date: Mon, 20 Jun 2016 09:41:44 +0200 [thread overview]
Message-ID: <57679E38.3080901@samsung.com> (raw)
In-Reply-To: <57647DBD.2010406@ti.com>
On 06/18/2016 12:46 AM, Andrew F. Davis wrote:
> On 06/15/2016 01:48 AM, Jacek Anaszewski wrote:
>> Hi Andrew,
>>
>> Thanks for the patch.
>>
>> Please address the issue [1] raised by test bot and resubmit.
>>
>> Thanks,
>> Jacek Anaszewski
>>
>> [1] https://lkml.org/lkml/2016/6/13/1091
>>
>
> It looks like some systems use 'gpio_led_register_device' to make an
> in-memory copy of their LED device table so the original can be removed
> as .init.rodata. This doesn't necessarily depend on the LED subsystem
> but it kind of seems useless when the rest of the subsystem is disabled.
>
> One solution could be to use a dummy 'gpio_led_register_device' when the
> subsystem is not enabled.
It sounds good. Please add a no-op version of gpio_led_register_device()
to include/leds.h, in a separate patch.
Thanks,
Jacek Anaszewski
> Another is just to remove the five or so uses
> of 'gpio_led_register_device' and have those systems register LED device
> tables like other systems do.
>
> If nether of these are acceptable then this patch can be dropped from
> this series for now.
>
> Thanks,
> Andrew
>
>> On 06/13/2016 10:02 PM, Andrew F. Davis wrote:
>>> When CONFIG_NEW_LEDS is not set make will still descend into the leds
>>> directory but nothing will be built. This produces unneeded build
>>> artifacts and messages in addition to slowing the build. Fix this here.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> ---
>>> drivers/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/Makefile b/drivers/Makefile
>>> index 567e32c..fa514d5 100644
>>> --- a/drivers/Makefile
>>> +++ b/drivers/Makefile
>>> @@ -127,7 +127,7 @@ obj-$(CONFIG_CPU_FREQ) += cpufreq/
>>> obj-$(CONFIG_CPU_IDLE) += cpuidle/
>>> obj-$(CONFIG_MMC) += mmc/
>>> obj-$(CONFIG_MEMSTICK) += memstick/
>>> -obj-y += leds/
>>> +obj-$(CONFIG_NEW_LEDS) += leds/
>>> obj-$(CONFIG_INFINIBAND) += infiniband/
>>> obj-$(CONFIG_SGI_SN) += sn/
>>> obj-y += firmware/
>>>
>>
>>
>
>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2016-06-20 7:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 20:01 [PATCH 00/12] Remove unneeded build directory traversals Andrew F. Davis
2016-06-13 20:02 ` [PATCH 01/12] gpio: Only descend into gpio directory when CONFIG_GPIOLIB is set Andrew F. Davis
2016-06-14 6:58 ` Linus Walleij
2016-06-13 20:02 ` [PATCH 02/12] pwm: Only descend into pwm directory when CONFIG_PWM " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 03/12] amba: Only descend into amba directory when CONFIG_ARM_AMBA " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 04/12] NFC: Only descend into nfc directory when CONFIG_NFC " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 05/12] macintosh: Only descend into directory when CONFIG_MACINTOSH_DRIVERS " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 06/12] hsi: Only descend into hsi directory when CONFIG_HSI " Andrew F. Davis
2016-06-14 0:36 ` kbuild test robot
2016-06-14 16:13 ` [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled Andrew F. Davis
2016-06-15 12:48 ` Sebastian Reichel
2016-06-13 20:02 ` [PATCH 07/12] auxdisplay: Only descend into directory when CONFIG_AUXDISPLAY is set Andrew F. Davis
2016-06-13 20:02 ` [PATCH 08/12] i2c: Only descend into i2c directory when CONFIG_I2C " Andrew F. Davis
2016-06-14 0:18 ` kbuild test robot
2016-06-13 20:02 ` [PATCH 09/12] [media] Only descend into directory when CONFIG_MEDIA_SUPPORT " Andrew F. Davis
2016-06-13 20:02 ` [PATCH 10/12] lguest: Only descend into lguest directory when CONFIG_LGUEST " Andrew F. Davis
2016-06-20 20:44 ` Rusty Russell
2016-06-13 20:02 ` [PATCH 11/12] mmc: Only descend into mmc directory when CONFIG_MMC " Andrew F. Davis
2016-06-14 1:33 ` kbuild test robot
2016-06-13 20:02 ` [PATCH 12/12] leds: Only descend into leds directory when CONFIG_NEW_LEDS " Andrew F. Davis
2016-06-14 0:19 ` kbuild test robot
2016-06-15 6:48 ` Jacek Anaszewski
2016-06-17 22:46 ` Andrew F. Davis
2016-06-20 7:41 ` Jacek Anaszewski [this message]
2016-06-20 22:13 ` [PATCH] leds: Add no-op gpio_led_register_device when LED subsystem is disabled Andrew F. Davis
2016-06-21 7:09 ` Jacek Anaszewski
2016-06-21 11:48 ` Andrew F. Davis
2016-06-21 13:11 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57679E38.3080901@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=afd@ti.com \
--cc=aloisio.almeida@openbossa.org \
--cc=lauro.venancio@openbossa.org \
--cc=lguest@lists.ozlabs.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mchehab@osg.samsung.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=rusty@rustcorp.com.au \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox